credentials: add end-to-end tests for JWT call credentials behavior#8818
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8818 +/- ##
==========================================
+ Coverage 83.22% 83.28% +0.06%
==========================================
Files 417 414 -3
Lines 32920 32805 -115
==========================================
- Hits 27397 27321 -76
+ Misses 4110 4075 -35
+ Partials 1413 1409 -4 🚀 New features to boost your workflow:
|
Pranjali-2501
left a comment
Contributor
There was a problem hiding this comment.
@iamrajiv , Thank you for taking the initiative to add the tests.
Pranjali-2501
approved these changes
Jan 29, 2026
Pranjali-2501
left a comment
Contributor
There was a problem hiding this comment.
The test looks good to me. I have minor nits.
Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
Contributor
|
@easwars , assigning it to you for second review. |
easwars
reviewed
Jan 29, 2026
Contributor
|
@iamrajiv I'm sorry. I just realized that some of my comments are in direct contradiction to some of the previous comments made as part of the review process and now you are having to do double work. |
Contributor
Author
|
No worries at all, @easwars! I appreciate the thorough review. The feedback to split into focused tests makes sense it's much cleaner and easier to debug now. Thanks for taking the time to review! |
easwars
reviewed
Feb 3, 2026
easwars
left a comment
Contributor
There was a problem hiding this comment.
Changes look good to me. Just a bunch of minor nits this time around.
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 10, 2026
…rpc#8818) This adds e2e style tests to verify that when JWT call credentials (which require transport security) are used with an insecure transport, the RPC fails with a meaningful error as expected per gRFC A97. Fixes grpc#8635 RELEASE NOTES: none --------- Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
…rpc#8818) This adds e2e style tests to verify that when JWT call credentials (which require transport security) are used with an insecure transport, the RPC fails with a meaningful error as expected per gRFC A97. Fixes grpc#8635 RELEASE NOTES: none --------- Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds e2e style tests to verify that when JWT call credentials (which require transport security) are used with an insecure transport, the RPC fails with a meaningful error as expected per gRFC A97.
Fixes #8635
RELEASE NOTES: none