outlierdetection: Remove UpdateAddresses handling#8810
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8810 +/- ##
==========================================
+ Coverage 83.25% 83.28% +0.03%
==========================================
Files 417 417
Lines 32978 32920 -58
==========================================
- Hits 27457 27419 -38
+ Misses 4106 4093 -13
+ Partials 1415 1408 -7
🚀 New features to boost your workflow:
|
easwars
approved these changes
Jan 9, 2026
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| t.Fatalf("timed out waiting for subconn to be removed from endpoint map") |
Contributor
There was a problem hiding this comment.
Nit: Here and elsewhere where it makes sense, please start the test error message with upper case.
Contributor
Author
There was a problem hiding this comment.
Fixed the capitalisation.
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
Following the dual-stack changes that established `pick_first` as the universal leaf policy and the subsequent removal of the legacy `pick_first` implementation, `ClientConn.UpdateAddresses` is no longer utilized within the xDS LB policy tree. When addresses change, old `SubConns` are now shut down and new ones are created. This PR makes `UpdateAddresses` a no-op and removes the corresponding test. Additionally, it ensures the `subConnWrapper` is removed from the ejection/unejection map when a SubConn closes to prevent memory leaks. RELEASE NOTES: N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the dual-stack changes that established
pick_firstas the universal leaf policy and the subsequent removal of the legacypick_firstimplementation,ClientConn.UpdateAddressesis no longer utilized within the xDS LB policy tree. When addresses change, oldSubConnsare now shut down and new ones are created.This PR makes
UpdateAddressesa no-op and removes the corresponding test. Additionally, it ensures thesubConnWrapperis removed from the ejection/unejection map when a SubConn closes to prevent memory leaks.RELEASE NOTES: N/A