xds: Migrate Addresses usages to Endpoints#8804
Merged
arjan-bal merged 2 commits intoJan 7, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8804 +/- ##
==========================================
+ Coverage 83.26% 83.28% +0.02%
==========================================
Files 418 417 -1
Lines 33004 32978 -26
==========================================
- Hits 27480 27465 -15
+ Misses 4109 4100 -9
+ Partials 1415 1413 -2
🚀 New features to boost your workflow:
|
easwars
approved these changes
Jan 6, 2026
| ai, ok := getAddrInfo(ep) | ||
| if !ok { | ||
| return fmt.Errorf("xds_wrr_locality: missing locality weight information in address %q", addr) | ||
| return fmt.Errorf("xds_wrr_locality: missing locality weight information in address %q", ep) |
Contributor
There was a problem hiding this comment.
Nit: s/in address/in endpoint/
| return endpoint | ||
| } | ||
|
|
||
| // GetLocalityIDFromEndpoint returns the locality ID of ep. |
Contributor
There was a problem hiding this comment.
Nit: Can we drop the Get from this function name?
Contributor
Author
There was a problem hiding this comment.
Renamed the function.
| } | ||
| } | ||
|
|
||
| // endpointsToAddrs flattens a list of endpoints to addresses to maintain |
Contributor
There was a problem hiding this comment.
Could you please file an issue for this with enough details and mark it "Help Wanted" and link it in here? Thanks.
Contributor
Author
There was a problem hiding this comment.
Filed #8809 and referenced it in the comment here.
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
This change migrates usages of ResolverState.Addresses to ResolverState.Endpoints. Prior to Dualstack support, xDS LB policies relied exclusively on the `Addresses` field. As part of the Dualstack initiative, these policies were updated to support both `Endpoints` and `Addresses`. This PR is the final step to deprecate the `Addresses` propagation logic in favor of relying solely on `Endpoints`. RELEASE NOTES: N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change migrates usages of ResolverState.Addresses to ResolverState.Endpoints. Prior to Dualstack support, xDS LB policies relied exclusively on the
Addressesfield. As part of the Dualstack initiative, these policies were updated to support bothEndpointsandAddresses. This PR is the final step to deprecate theAddressespropagation logic in favor of relying solely onEndpoints.RELEASE NOTES: N/A