xds: Revert workaround to get SubConn locality#8802
Merged
Conversation
923674b to
6d59e36
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8802 +/- ##
==========================================
+ Coverage 83.26% 83.31% +0.04%
==========================================
Files 418 417 -1
Lines 33004 32972 -32
==========================================
- Hits 27480 27469 -11
+ Misses 4109 4095 -14
+ Partials 1415 1408 -7
🚀 New features to boost your workflow:
|
easwars
approved these changes
Jan 7, 2026
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
grpc#7378 added an internal API to propagate the locality ID of each address used by a subchannel. This was required because the legacy pick_first implementation created subchannels with multiple addresses, each with a potentially different locality. Since the legacy implementation has been removed, and the new pick_first creates subchannels with only a single address, this workaround is now redundant. This PR also make the `UpdateAddresses` method of `clusterImpl` balancer a no-op since none of the leaf policies use it anymore. RELEASE NOTES: N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7378 added an internal API to propagate the locality ID of each address used by a subchannel. This was required because the legacy pick_first implementation created subchannels with multiple addresses, each with a potentially different locality. Since the legacy implementation has been removed, and the new pick_first creates subchannels with only a single address, this workaround is now redundant. This PR also make the
UpdateAddressesmethod ofclusterImplbalancer a no-op since none of the leaf policies use it anymore.RELEASE NOTES: N/A