xds/clusterresolver: implement gRFC A61 changes for LOGICAL_DNS clusters#8733
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8733 +/- ##
==========================================
- Coverage 83.42% 83.35% -0.07%
==========================================
Files 414 414
Lines 32751 32754 +3
==========================================
- Hits 27322 27302 -20
- Misses 4040 4057 +17
- Partials 1389 1395 +6
🚀 New features to boost your workflow:
|
easwars
reviewed
Dec 1, 2025
Contributor
|
This change probably needs a release note. |
easwars
reviewed
Dec 3, 2025
easwars
reviewed
Dec 16, 2025
easwars
approved these changes
Jan 29, 2026
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 10, 2026
…ers (grpc#8733) Fixes : grpc#8153 This PR implements the "Changes to Logical DNS Clusters" section of [gRFC A61 (IPv4/IPv6 Dual-stack Backends)](https://github.com/grpc/proposal/blob/master/A61-IPv4-IPv6-dualstack-backends.md#changes-to-logical-dns-clusters). Currently, `LOGICAL_DNS` clusters in the xDS cluster resolver have their Load Balancing policy hard-coded to `pick_first`. This ensures the semantics of connecting to only one address at a time. This PR updates the `xds_cluster_resolver` logic. The `buildClusterImplConfigForDNS` function removes the hard-coded `pick_first` policy restriction for `LOGICAL_DNS` clusters, allowing them to use the configured LB policy. Also, in the DNS update handler, all resolved addresses are now grouped into a single `resolver.Endpoint`. This ensures that regardless of the configured parent LB policy, the child policy sees a single "backend" endpoint containing all addresses. RELEASE NOTES: * xds: `LOGICAL_DNS` clusters now honor the LB policy configured in the cluster resource, rather than defaulting to a hardcoded `pick_first` policy.
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
…ers (grpc#8733) Fixes : grpc#8153 This PR implements the "Changes to Logical DNS Clusters" section of [gRFC A61 (IPv4/IPv6 Dual-stack Backends)](https://github.com/grpc/proposal/blob/master/A61-IPv4-IPv6-dualstack-backends.md#changes-to-logical-dns-clusters). Currently, `LOGICAL_DNS` clusters in the xDS cluster resolver have their Load Balancing policy hard-coded to `pick_first`. This ensures the semantics of connecting to only one address at a time. This PR updates the `xds_cluster_resolver` logic. The `buildClusterImplConfigForDNS` function removes the hard-coded `pick_first` policy restriction for `LOGICAL_DNS` clusters, allowing them to use the configured LB policy. Also, in the DNS update handler, all resolved addresses are now grouped into a single `resolver.Endpoint`. This ensures that regardless of the configured parent LB policy, the child policy sees a single "backend" endpoint containing all addresses. RELEASE NOTES: * xds: `LOGICAL_DNS` clusters now honor the LB policy configured in the cluster resource, rather than defaulting to a hardcoded `pick_first` policy.
This was referenced Apr 23, 2026
Closed
Closed
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #8153
This PR implements the "Changes to Logical DNS Clusters" section of gRFC A61 (IPv4/IPv6 Dual-stack Backends).
Currently,
LOGICAL_DNSclusters in the xDS cluster resolver have their Load Balancing policy hard-coded topick_first. This ensures the semantics of connecting to only one address at a time.This PR updates the
xds_cluster_resolverlogic. ThebuildClusterImplConfigForDNSfunction removes the hard-codedpick_firstpolicy restriction forLOGICAL_DNSclusters, allowing them to use the configured LB policy.Also, in the DNS update handler, all resolved addresses are now grouped into a single
resolver.Endpoint. This ensures that regardless of the configured parent LB policy, the child policy sees a single "backend" endpoint containing all addresses.RELEASE NOTES:
LOGICAL_DNSclusters now honor the LB policy configured in the cluster resource, rather than defaulting to a hardcodedpick_firstpolicy.