xdsclient: revert #8369: delay resource cache deletion#8527
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8527 +/- ##
==========================================
+ Coverage 81.86% 81.91% +0.04%
==========================================
Files 412 412
Lines 40518 40451 -67
==========================================
- Hits 33172 33137 -35
+ Misses 5953 5924 -29
+ Partials 1393 1390 -3
🚀 New features to boost your workflow:
|
dfawley
approved these changes
Aug 21, 2025
eshitachandwani
pushed a commit
to eshitachandwani/grpc-go
that referenced
this pull request
Aug 29, 2025
The change being reverted here (grpc#8369) is a prime suspect for a race that can show up with the following sequence of events: - create a new gRPC channel with the `xds:///` scheme - make an RPC - close the channel - repeat (possibly from multiple goroutines) The observable behavior from the race is that the xDS client thinks that a Listener resource is removed by the control plane when it clearly is not. This results in the user's gRPC channel moving to TRANSIENT_FAILURE and subsequent RPC failures. The reason the above mentioned PR is not being rolled back using `git revert` is because the xds directory structure has changed significantly since the time the PR was originally merged. Manually performing the revert seemed much easier. RELEASE NOTES: * xdsclient: Revert a change that introduces a race with xDS resource processing, leading to RPC failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change being reverted here (#8369) is a prime suspect for a race that can show up with the following sequence of events:
xds:///schemeThe observable behavior from the race is that the xDS client thinks that a Listener resource is removed by the control plane when it clearly is not. This results in the user's gRPC channel moving to TRANSIENT_FAILURE and subsequent RPC failures.
The reason the above mentioned PR is not being rolled back using
git revertis because the xds directory structure has changed significantly since the time the PR was originally merged. Manually performing the revert seemed much easier.RELEASE NOTES: