endpointsharding: Export parsed pickfirst config instead of json string#8007
Merged
arjan-bal merged 1 commit intogrpc:masterfrom Jan 15, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8007 +/- ##
==========================================
- Coverage 82.13% 82.04% -0.09%
==========================================
Files 381 381
Lines 38542 38545 +3
==========================================
- Hits 31655 31626 -29
- Misses 5575 5599 +24
- Partials 1312 1320 +8
|
e902bb7 to
390f93f
Compare
arjan-bal
commented
Jan 13, 2025
| var PickFirstConfig string | ||
| var ( | ||
| // PickFirstConfig is a pick first config without shuffling enabled. | ||
| PickFirstConfig serviceconfig.LoadBalancingConfig |
Contributor
Author
There was a problem hiding this comment.
This is a pubic API change, but the package is experimental. @dfawley should I export a new var instead of replacing the existing one?
Member
There was a problem hiding this comment.
I think we should be fine to just change it since it's experimental and very new.
dfawley
approved these changes
Jan 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Jan 26, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the users of
PickFirstConfigneeded to handle parsing errors while using the exported config. This PR exports the parsed config making the usage simpler for users.RELEASE NOTES: