deps: bump github.com/envoyproxy/go-control-plane to v0.13.4#7974
Conversation
8fa3f25 to
f45d96d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7974 +/- ##
==========================================
- Coverage 82.28% 82.03% -0.26%
==========================================
Files 381 381
Lines 38539 38539
==========================================
- Hits 31712 31614 -98
- Misses 5535 5602 +67
- Partials 1292 1323 +31 |
ba95fb4 to
a55b2ed
Compare
16b8025 to
12f1107
Compare
b285016 to
c9b5007
Compare
c9b5007 to
0f3ba07
Compare
28eb49d to
dc3feff
Compare
scripts/vet.sh
Outdated
| CredsBundle is deprecated: | ||
| internal.Logger is deprecated: | ||
| Metadata is deprecated: use Attributes instead. | ||
| Metadata is deprecated: |
There was a problem hiding this comment.
Why was this needed? The deprecation message is still the same:
Line 119 in 6f41085
There was a problem hiding this comment.
There is a deprecation on GetMetadata that is not caught otherwise
There was a problem hiding this comment.
By the way, would you be open to use golangci-lint to simplify linters maintenance ?
There was a problem hiding this comment.
The new deprecation is coming from envoy/config/rbac/v3/rbac.proto.
I think we should add a new entry instead of relaxing this pattern to avoid accidentally hiding other deprecation warnings in the future.
GetMetadata is deprecated: Marked as deprecated in envoy/config/rbac
There was a problem hiding this comment.
By the way, would you be open to use golangci-lint to simplify linters maintenance ?
I think we've been able to achieve what we need using vet and staticcheck directly combined with regexes, so there wasn't a need to add a new dependency. If you think think using golangci-lint has significant benefits, please do file an issue and we can discuss this.
fcaf085 to
fd1e67f
Compare
fd1e67f to
e56bba9
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
e56bba9 to
64d6914
Compare
arjan-bal
left a comment
There was a problem hiding this comment.
LGTM, adding another reviewers for a second approval.
| github.com/census-instrumentation/opencensus-proto v0.4.1 // indirect | ||
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
| github.com/envoyproxy/go-control-plane v0.13.1 // indirect | ||
| github.com/envoyproxy/go-control-plane/envoy v1.32.3 // indirect |
There was a problem hiding this comment.
(I'm extremely happy to see a v1 here -- thanks!!)
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Description
This updates
github.com/envoyproxy/go-control-planeto v0.13.4 and import newgithub.com/envoyproxy/go-control-plane/envoymoduleRelated to envoyproxy/go-control-plane#1074
RELEASE NOTES: None