leastrequest: Delegate subchannel creation to pickfirst#7969
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7969 +/- ##
==========================================
- Coverage 82.17% 82.01% -0.16%
==========================================
Files 381 381
Lines 38546 38581 +35
==========================================
- Hits 31676 31644 -32
- Misses 5560 5612 +52
- Partials 1310 1325 +15
|
dfawley
reviewed
Jan 9, 2025
dfawley
left a comment
Member
There was a problem hiding this comment.
It seems like some new test cases should be needed, in light of the changes here?
2e60697 to
8135a2a
Compare
dfawley
approved these changes
Jan 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Jan 26, 2025
20 tasks
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the least request balancer to defer to pick first instead of creating and handling SubConns itself. This is part of Dualstack, and makes this a petiole.
RELEASE NOTES: