xds: Add a test for incorrect load reporting when using pickfirst with servers in multiple localities#7357
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7357 +/- ##
==========================================
- Coverage 81.47% 81.32% -0.16%
==========================================
Files 348 348
Lines 26761 26755 -6
==========================================
- Hits 21804 21758 -46
- Misses 3772 3794 +22
- Partials 1185 1203 +18
|
33c0345 to
02fa7a4
Compare
easwars
requested changes
Jun 26, 2024
fea5c9e to
503a123
Compare
arjan-bal
commented
Jun 27, 2024
471c9e3 to
b738469
Compare
b738469 to
c1bdd04
Compare
easwars
reviewed
Jun 27, 2024
easwars
left a comment
Contributor
There was a problem hiding this comment.
Looks great now. Just some very minor nits.
easwars
approved these changes
Jun 27, 2024
easwars
approved these changes
Jun 28, 2024
townba
added a commit
to townba/grpc-go
that referenced
this pull request
Jul 1, 2024
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addressed the first task for #7339, adding a unit test that fails. The test presently asserts that the incorrect region received the load until the bug has been fixed:
The test asserts the following after sending 1 rpc:
Then we stop server 1, send another rpc and assert the following:
Issue: #7339
RELEASE NOTES: None