transport: allow stream cancellation on the server when blocked on flow control#8528
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8528 +/- ##
==========================================
+ Coverage 81.87% 82.08% +0.20%
==========================================
Files 413 412 -1
Lines 40518 40453 -65
==========================================
+ Hits 33176 33207 +31
+ Misses 5967 5875 -92
+ Partials 1375 1371 -4
🚀 New features to boost your workflow:
|
051097c to
26176d2
Compare
26176d2 to
c1c5477
Compare
|
The fix did not make into the release? |
Contributor
Author
We didn't want to delay the 1.75 release too much. We will perform patch releases once this PR is merged. Reviews have been slow due to the annual gRPConf that happened a couple of days ago. |
dfawley
approved these changes
Sep 3, 2025
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Sep 4, 2025
…ow control (grpc#8528) Fixes: grpc#8517 This change allows `t.closeStream()` to be executed even if the stream state is `done`. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause. RELEASE NOTES: * server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Sep 4, 2025
…ow control (grpc#8528) Fixes: grpc#8517 This change allows `t.closeStream()` to be executed even if the stream state is `done`. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause. RELEASE NOTES: * server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Sep 4, 2025
…ow control (grpc#8528) Fixes: grpc#8517 This change allows `t.closeStream()` to be executed even if the stream state is `done`. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause. RELEASE NOTES: * server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Sep 4, 2025
…ow control (grpc#8528) Fixes: grpc#8517 This change allows `t.closeStream()` to be executed even if the stream state is `done`. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause. RELEASE NOTES: * server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Sep 4, 2025
…ow control (grpc#8528) Fixes: grpc#8517 This change allows `t.closeStream()` to be executed even if the stream state is `done`. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause. RELEASE NOTES: * server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8517
This change allows
t.closeStream()to be executed even if the stream state isdone. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause.RELEASE NOTES: