Cherry-pick #8528 to v1.73.x#8553
Merged
Merged
Conversation
…ow control (grpc#8528) Fixes: grpc#8517 This change allows `t.closeStream()` to be executed even if the stream state is `done`. This is required to allow streams to be cancelled to timed out. See issue for detailed root cause. RELEASE NOTES: * server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.73.x #8553 +/- ##
===========================================
- Coverage 82.19% 81.85% -0.35%
===========================================
Files 419 419
Lines 42021 42021
===========================================
- Hits 34538 34395 -143
- Misses 6012 6168 +156
+ Partials 1471 1458 -13
🚀 New features to boost your workflow:
|
dfawley
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #8528
Related issue: #8517
RELEASE NOTES: