Skip to content

Compile fix#83

Merged
jboeuf merged 1 commit intogrpc:masterfrom
ctiller:fix
Jan 16, 2015
Merged

Compile fix#83
jboeuf merged 1 commit intogrpc:masterfrom
ctiller:fix

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Jan 16, 2015

No description provided.

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 16, 2015

Introduced by work on #71

@jboeuf
Copy link
Copy Markdown
Contributor

jboeuf commented Jan 16, 2015

Sorry about that... I kicked a build after my changes and everything was fine... I don't really understand, maybe I was on the wrong branch....

jboeuf added a commit that referenced this pull request Jan 16, 2015
@jboeuf jboeuf merged commit 19cdb35 into grpc:master Jan 16, 2015
@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 16, 2015

make by itself doesn't build & run tests... you probably want to get in the
habit of:

tools/run_tests/run_tests.py -c dbg

to do so

On Fri Jan 16 2015 at 8:53:59 AM jboeuf notifications@github.com wrote:

Merged #83 #83.


Reply to this email directly or view it on GitHub
#83 (comment).

@jboeuf
Copy link
Copy Markdown
Contributor

jboeuf commented Jan 16, 2015

OK, will do. Is there a central place for documentation on these things? I
looks like I'm gathering bits and pieces from different sources (like the
fact that I have to install protobuf manually for example).

On Fri, Jan 16, 2015 at 8:57 AM, Craig Tiller notifications@github.com
wrote:

make by itself doesn't build & run tests... you probably want to get in
the
habit of:

tools/run_tests/run_tests.py -c dbg

to do so

On Fri Jan 16 2015 at 8:53:59 AM jboeuf notifications@github.com wrote:

Merged #83 #83.


Reply to this email directly or view it on GitHub
#83 (comment).


Reply to this email directly or view it on GitHub
#83 (comment).

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 16, 2015

I started a page on the wiki:
https://github.com/google/grpc/wiki/C-C---development-knowhow

On Fri Jan 16 2015 at 8:59:25 AM jboeuf notifications@github.com wrote:

OK, will do. Is there a central place for documentation on these things? I
looks like I'm gathering bits and pieces from different sources (like the
fact that I have to install protobuf manually for example).

On Fri, Jan 16, 2015 at 8:57 AM, Craig Tiller notifications@github.com
wrote:

make by itself doesn't build & run tests... you probably want to get in
the
habit of:

tools/run_tests/run_tests.py -c dbg

to do so

On Fri Jan 16 2015 at 8:53:59 AM jboeuf notifications@github.com
wrote:

Merged #83 #83.


Reply to this email directly or view it on GitHub
#83 (comment).


Reply to this email directly or view it on GitHub
#83 (comment).


Reply to this email directly or view it on GitHub
#83 (comment).

@jboeuf
Copy link
Copy Markdown
Contributor

jboeuf commented Jan 16, 2015

OK, I added the other steps to it.

On Fri, Jan 16, 2015 at 9:03 AM, Craig Tiller notifications@github.com
wrote:

I started a page on the wiki:
https://github.com/google/grpc/wiki/C-C---development-knowhow

On Fri Jan 16 2015 at 8:59:25 AM jboeuf notifications@github.com wrote:

OK, will do. Is there a central place for documentation on these things?
I
looks like I'm gathering bits and pieces from different sources (like
the
fact that I have to install protobuf manually for example).

On Fri, Jan 16, 2015 at 8:57 AM, Craig Tiller notifications@github.com

wrote:

make by itself doesn't build & run tests... you probably want to get
in
the
habit of:

tools/run_tests/run_tests.py -c dbg

to do so

On Fri Jan 16 2015 at 8:53:59 AM jboeuf notifications@github.com
wrote:

Merged #83 #83.


Reply to this email directly or view it on GitHub
#83 (comment).


Reply to this email directly or view it on GitHub
#83 (comment).


Reply to this email directly or view it on GitHub
#83 (comment).


Reply to this email directly or view it on GitHub
#83 (comment).

stanley-cheung referenced this pull request in stanley-cheung/grpc Aug 27, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants