Grpc ruby add rubocop fix lint style issues#82
Merged
murgatroid99 merged 3 commits intogrpc:masterfrom Jan 16, 2015
tbetbetbe:grpc_ruby_add_rubocop_fix_lint_style_issues
Merged
Grpc ruby add rubocop fix lint style issues#82murgatroid99 merged 3 commits intogrpc:masterfrom tbetbetbe:grpc_ruby_add_rubocop_fix_lint_style_issues
murgatroid99 merged 3 commits intogrpc:masterfrom
tbetbetbe:grpc_ruby_add_rubocop_fix_lint_style_issues
Conversation
added 3 commits
January 16, 2015 02:58
- add rubocop as a dev dependency - fixed many style violations it reported, often using --auto-correct - add a rubocop config - .rubocop.yml shows the exceptions - .rubocopy_todo.yml tracks outstanding style issues - adds a rake task to allow rubocop styling checks to be automated
murgatroid99
added a commit
that referenced
this pull request
Jan 16, 2015
…style_issues Grpc ruby add rubocop fix lint style issues
lalo
pushed a commit
to lalo/grpc
that referenced
this pull request
Oct 19, 2017
CS1591 is "Missing XML comment for publicly visible type or member". Emit a 'pragma warning disable' line in generated C# code so that projects that build will all warnings enabled don't have to add XML documentation comments to their Bond-generated files. Update the codegen golden master test files. Add the test/codegen/no-warnings target that has all warnings enabled and warnings as errors so that a new warning will fail to build. Closes grpc#82.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks large, but this is just a set of style changes.
This re-styles all non-generated ruby code to match: https://github.com/bbatsov/ruby-style-guide, and adds a rake task so that style can be checked and potential fixed automatically.