Cache for successful test runs#74
Merged
nicolasnoble merged 2 commits intogrpc:masterfrom Jan 16, 2015
ctiller:run_tests_fast
Merged
Cache for successful test runs#74nicolasnoble merged 2 commits intogrpc:masterfrom ctiller:run_tests_fast
nicolasnoble merged 2 commits intogrpc:masterfrom
ctiller:run_tests_fast
Conversation
By default don't re-run tests that have already run successfully, to reduce latency between making a change and seeing if it fixed the last thing that you were trying to fix.
tools/run_tests/run_tests.py
Outdated
Member
Author
There was a problem hiding this comment.
Fixed
On Thu Jan 15 2015 at 5:22:22 PM Nicolas Noble notifications@github.com
wrote:
In tools/run_tests/run_tests.py
#74 (diff):
- def init(self):
- self._last_successful_run = {}
- def should_run(self, cmdline, bin_hash):
- cmdline = ' '.join(cmdline)
- if cmdline not in self._last_successful_run:
return True- if self._last_successful_run[cmdline] != bin_hash:
return True- return False
- def finished(self, cmdline, bin_hash):
- self._last_successful_run[' '.join(cmdline)] = bin_hash
- def dump(self):
- return [{'cmdline': k, 'hash': v} for k, v in self._last_successful_run.iteritems()]
line length :-P
—
Reply to this email directly or view it on GitHub
https://github.com/google/grpc/pull/74/files#r23057960.
nicolasnoble
added a commit
that referenced
this pull request
Jan 16, 2015
Cache for successful test runs
stanley-cheung
referenced
this pull request
in stanley-cheung/grpc
Aug 27, 2015
Removing java examples from grpc-common
apolcyn
referenced
this pull request
in apolcyn/grpc
Jul 25, 2016
Added section on Blocking and Non Blocking in the principles post.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default don't re-run tests that have already run successfully, to
reduce latency between making a change and seeing if it fixed the last
thing that you were trying to fix.