Removing "using namespace std" everywhere.#72
Merged
yang-g merged 2 commits intogrpc:masterfrom Jan 16, 2015
nicolasnoble:no-std
Merged
Removing "using namespace std" everywhere.#72yang-g merged 2 commits intogrpc:masterfrom nicolasnoble:no-std
yang-g merged 2 commits intogrpc:masterfrom
nicolasnoble:no-std
Conversation
Member
|
+1 |
Contributor
There was a problem hiding this comment.
Should we add
#include <map>Haha this time markdown works...
Contributor
Author
|
Sure, why not. I simply mass-modified occurrences of map, vector and string, but I can also clean the inclusions a bit. |
Contributor
Author
|
Done. |
yang-g
added a commit
that referenced
this pull request
Jan 16, 2015
Removing "using namespace std" everywhere.
stanley-cheung
referenced
this pull request
in stanley-cheung/grpc
Aug 27, 2015
Updating java package for helloworld.proto
lalo
added a commit
to lalo/grpc
that referenced
this pull request
Oct 19, 2017
- Validate default value type mistmatches (fixes grpc#72, fixes grpc#128) - Validate default value out-of-range values (fixes grpc#73) - Fail when struct field has default value of 'nothing' (fixes grpc#164) - Fail when enum field doesn't have default value (fixes grpc#177) - Validate default value of type aliases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.