Simplify Node Windows tests slightly#5603
Merged
murgatroid99 merged 1 commit intogrpc:masterfrom Mar 4, 2016
Merged
Conversation
Simplify command that removes OpenSSL headers and remove now-extraneous post-test script.
Contributor
|
Beautiful! LGTM, merge once green. |
murgatroid99
added a commit
that referenced
this pull request
Mar 4, 2016
Simplify Node Windows tests slightly
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Feb 12, 2021
…rpc#6018) *Description*: Fixes grpc#5603 *Risk Level*: Low (not changing flow, add more info) *Testing*: unit test, *Docs Changes*: Added *Release Notes*: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io> Mirrored from https://github.com/envoyproxy/envoy @ b41ba5925a4e93d22a86c6501d63314ccf0d79f3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify command that removes OpenSSL headers and remove now-extraneous
post-test script.
At least on the Windows experiment test setup, the tests now pass: https://grpc-testing.appspot.com/view/All/job/windows-experiment/34/console.
I think this will finally fix #5343 once and for all.