Skip to content

Improve perf smoke test stability#5598

Merged
ctiller merged 3 commits intogrpc:masterfrom
vjpai:make_qps_great_again
Mar 4, 2016
Merged

Improve perf smoke test stability#5598
ctiller merged 3 commits intogrpc:masterfrom
vjpai:make_qps_great_again

Conversation

@vjpai
Copy link
Copy Markdown
Contributor

@vjpai vjpai commented Mar 4, 2016

Right now, perf smoke tests are broken (even though the perf tests integrated into basic tests are running), and this may be because we have issues related to keeping the workers alive from test to test. This stability problem needs a longer-term solution, but for now we need to be able to have green smoke tests.

ctiller added a commit that referenced this pull request Mar 4, 2016
@ctiller
Merge pull request #5598 from vjpai/make_qps_great_again
3ad5348 
Improve perf smoke test stability
@ctiller ctiller merged commit 3ad5348 into grpc:master Mar 4, 2016
@ctiller
Copy link
Copy Markdown
Member

ctiller commented Mar 4, 2016

Ugly, but it works.

@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Mar 4, 2016

This change did not work.
https://grpc-testing.appspot.com/job/gRPC_performance_master/2086/console

Given that it did not work, I believe that it should be reverted.

@ctiller
Copy link
Copy Markdown
Member

ctiller commented Mar 4, 2016

agree

On Fri, Mar 4, 2016 at 2:42 PM Vijay Pai notifications@github.com wrote:

This change did not work.
https://grpc-testing.appspot.com/job/gRPC_performance_master/2086/console

Given that it did not work, I believe that it should be reverted.

—
Reply to this email directly or view it on GitHub
#5598 (comment).

@ctiller
Copy link
Copy Markdown
Member

ctiller commented Mar 4, 2016

Do pull requests go through a different list?

@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Mar 4, 2016

List? It's the same script, but on a different Jenkins task. I think it
runs on the same box, though.

On Fri, Mar 4, 2016 at 2:44 PM Craig Tiller notifications@github.com
wrote:

Do pull requests go through a different list?

—
Reply to this email directly or view it on GitHub
#5598 (comment).

@vjpai vjpai mentioned this pull request Mar 4, 2016
Merged
@vjpai vjpai deleted the make_qps_great_again branch March 26, 2016 07:16
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ctiller ctiller

Labels

area/performance cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjpai @ctiller @googlebot