Ensure that no #includes are inside of a namespace.#5547
Merged
vjpai merged 3 commits intogrpc:masterfrom Mar 4, 2016
Merged
Conversation
0a70c06 to
2a8c280
Compare
Contributor
|
LGTM. I would merge, except this PR has merge conflicts. Please resolve and I'll merge. |
Contributor
Author
|
Done |
vjpai
added a commit
that referenced
this pull request
Mar 4, 2016
Ensure that no #includes are inside of a namespace.
Contributor
|
We'll need to reopen this after the fixit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via David Jones. Thanks!