Rewrite the Node library to use the new core call API#504
Merged
tbetbetbe merged 29 commits intogrpc:masterfrom Feb 18, 2015
murgatroid99:node_new_core_api
Merged
Rewrite the Node library to use the new core call API#504tbetbetbe merged 29 commits intogrpc:masterfrom murgatroid99:node_new_core_api
tbetbetbe merged 29 commits intogrpc:masterfrom
murgatroid99:node_new_core_api
Conversation
Member
Author
|
I would just like to note that this change decreased median unary call latency to about 200 us. |
Member
|
\o/ On Thu Feb 12 2015 at 3:53:14 PM Michael Lumish notifications@github.com
|
Member
|
I think the C++ stuff looks good at this point. |
Closed
src/node/src/client.js
Outdated
Contributor
There was a problem hiding this comment.
Add a documentation comment
Member
Author
|
I added the missing documentation. |
tbetbetbe
added a commit
that referenced
this pull request
Feb 18, 2015
Rewrite the Node library to use the new core call API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #403. It also closes #177.
I'd appreciate if @ctiller takes a look at the C++ parts.