Skip to content

Cleanup makefiles#47

Merged
nicolasnoble merged 5 commits intogrpc:masterfrom
ctiller:makeclean
Jan 15, 2015
Merged

Cleanup makefiles#47
nicolasnoble merged 5 commits intogrpc:masterfrom
ctiller:makeclean

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Jan 15, 2015

Speed up 'make clean', actually use dependency information (and generate them in one pass).
The individual commit comments make sense to read for further info.

It's safe enough to just delete the build product directories.
If we don't have a .o, we don't need dependencies, so skip the setup
step of building them. Instead, when building the .o, we generate the
.dep and output it (to objs/ to make the rules a little easier). The
next run of make will include the dep file and any dependencies will be
picked up.

This change also disables the disabling of dependency checking if we
have zlib or openssl being compiled from third_party. Additionally it
inverts the logic for including dependencies from ONLY if we are doing a
clean to ONLY if we are NOT doing a clean.
They're trivially recreatable from the _OBJS variables now.
Files that have dependencies on phony targets are always remade, leading
to much unnecessary compiling of the C++ tests.
nicolasnoble added a commit that referenced this pull request Jan 15, 2015
@nicolasnoble nicolasnoble merged commit db2963e into grpc:master Jan 15, 2015
stanley-cheung referenced this pull request in stanley-cheung/grpc Aug 27, 2015
apolcyn referenced this pull request in apolcyn/grpc Jul 25, 2016
Added new overview diagram
nicolasnoble pushed a commit that referenced this pull request Jan 20, 2017
…pointed-do-you-start-to-just-accept-good-faith-or-get-jaded-about-good-faith

Fix Python memory errors
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants