Cleanup makefiles#47
Merged
nicolasnoble merged 5 commits intogrpc:masterfrom Jan 15, 2015
ctiller:makeclean
Merged
Conversation
It's safe enough to just delete the build product directories.
If we don't have a .o, we don't need dependencies, so skip the setup step of building them. Instead, when building the .o, we generate the .dep and output it (to objs/ to make the rules a little easier). The next run of make will include the dep file and any dependencies will be picked up. This change also disables the disabling of dependency checking if we have zlib or openssl being compiled from third_party. Additionally it inverts the logic for including dependencies from ONLY if we are doing a clean to ONLY if we are NOT doing a clean.
They're trivially recreatable from the _OBJS variables now.
Files that have dependencies on phony targets are always remade, leading to much unnecessary compiling of the C++ tests.
stanley-cheung
referenced
this pull request
in stanley-cheung/grpc
Aug 27, 2015
Update the ruby helloworld README.md
nicolasnoble
pushed a commit
that referenced
this pull request
Jan 20, 2017
…pointed-do-you-start-to-just-accept-good-faith-or-get-jaded-about-good-faith Fix Python memory errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up 'make clean', actually use dependency information (and generate them in one pass).
The individual commit comments make sense to read for further info.