Get MSAN, ASAN working for C#46
Conversation
MSAN, TSAN, ASAN need to see all the code. Valgrind, MSAN want -DPURIFY.
These libraries need to see all of the source code, so using system installed libraries is out of the question.
There was a problem hiding this comment.
That shouldn't work. We're missing a ZLIB_DEP somewhere down. (darn, I wish github would let me comment on arbitrary lines...)
There was a problem hiding this comment.
Something odd is going on with zlib - help accepted :)
On Thu Jan 15 2015 at 8:44:41 AM Nicolas Noble notifications@github.com
wrote:
In templates/Makefile.template
#46 (diff):@@ -189,7 +213,7 @@ endif
ifeq ($(HAS_SYSTEM_ZLIB),false)
ifeq ($(HAS_EMBEDDED_ZLIB),true)
-ZLIB_DEP = third_party/zlib/libz.a
+ZLIB_DEP = libs/$(CONFIG)/zlib/libz.aThat shouldn't work. We're missing a ZLIB_DEP somewhere down. (darn, I
wish github would let me comment on arbitrary lines...)—
Reply to this email directly or view it on GitHub
https://github.com/google/grpc/pull/46/files#r23023364.
There was a problem hiding this comment.
No worries, I'll share a commit to fix this shortly.
|
@nicolasnoble This article may help. |
Fixing zlib dependency build.
|
Nico's change gets zlib building right. |
|
Hang on: this doesn't build. |
|
make: *** No rule to make target |
|
Found the bug |
Get MSAN, ASAN working for C
…esome-dance-tune-y'all Fix Python errors
No description provided.