Fix interop Python test invocation#4323
Merged
jtattermusch merged 1 commit intogrpc:release-0_12from Dec 8, 2015
Merged
Conversation
The ideal fix would be to have a tox test command for running the interop server and client.
Contributor
There was a problem hiding this comment.
The absence of space between -r and requirements.txt on this line is a legitimate thing and not a typo, right?
Contributor
|
Change content looks fine; waiting on test results. |
Contributor
|
LGTM once interop tests pass. Currently it looks like it's failing because it can't get over PHP. |
Contributor
|
Ruby interop test failure is unrelated. |
jtattermusch
added a commit
that referenced
this pull request
Dec 8, 2015
Fix interop Python test invocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4317.
Fixes a fix that was missing a fix in said fix. The ideal fix would fix a
toxcommand fixating on the interop server and client.tl;dr: I'm a moose.
cc @nathanielmanistaatgoogle
cc @jcanizales