Skip to content

Make Python testing predictable again#4281

Merged
nathanielmanistaatgoogle merged 4 commits intogrpc:release-0_12from
soltanmm:LD50
Dec 5, 2015
Merged

Make Python testing predictable again#4281
nathanielmanistaatgoogle merged 4 commits intogrpc:release-0_12from
soltanmm:LD50

Conversation

@soltanmm
Copy link
Copy Markdown
Contributor

@soltanmm soltanmm commented Dec 4, 2015

Also simplifies (build|run)_python by using tox and generates coverage reports. Because why not.

@soltanmm
Make Python testing predictable again
7566c9a 
This reorganizes the Python code, scraps the current testing
infrastructure, and implements a simple test discovery and run script
based on the standard Python unittest library so we can trust that our
tests are running.
@soltanmm
Fix Python interop test invocation in run_interop_tests.py
0a9cc3c
@soltanmm soltanmm added this to the Point release 0.12 milestone Dec 4, 2015
@soltanmm soltanmm mentioned this pull request Dec 4, 2015
Closed
@soltanmm
Copy link
Copy Markdown
Contributor Author

soltanmm commented Dec 4, 2015

#4228 should probably go in first so that extension code coverage Just Works™.

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

nathanielmanistaatgoogle commented Dec 5, 2015

What's to be made of

Traceback (most recent call last):
  File "setup.py", line 128, in <module>
    bool(BUILD_WITH_CYTHON))
  File "setup.py", line 118, in cython_extensions
    import Cython.Build
ImportError: No module named Cython.Build

in the failed test run of this?

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

nathanielmanistaatgoogle commented Dec 5, 2015

Looks good content-wise.

@soltanmm
Copy link
Copy Markdown
Contributor Author

soltanmm commented Dec 5, 2015

The error on Jenkins was from a silly oversight on my part - fixed.

@soltanmm
Copy link
Copy Markdown
Contributor Author

soltanmm commented Dec 5, 2015

The other error which was also an oversight during fixing of the previous oversight has also been fixed.

nathanielmanistaatgoogle added a commit that referenced this pull request Dec 5, 2015
@nathanielmanistaatgoogle
Merge pull request #4281 from soltanmm/LD50
67140d0 
Make Python testing predictable again.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 67140d0 into grpc:release-0_12 Dec 5, 2015
@ctiller
Copy link
Copy Markdown
Member

ctiller commented Dec 5, 2015

... trained to mix concrete and sign complicated insurance forms by ...

@soltanmm soltanmm deleted the LD50 branch December 5, 2015 07:25
@jtattermusch jtattermusch mentioned this pull request Dec 7, 2015
Merged
@soltanmm soltanmm mentioned this pull request Dec 17, 2015
Closed
@soltanmm soltanmm mentioned this pull request Jan 12, 2016
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@nathanielmanistaatgoogle nathanielmanistaatgoogle

Labels

cla: yes lang/Python

Projects

None yet

Milestone

Point release 0.12

Development

Successfully merging this pull request may close these issues.

4 participants

@soltanmm @nathanielmanistaatgoogle @ctiller @googlebot