Introduce auth interceptor context for C# #4260
Merged
jboeuf merged 1 commit intogrpc:release-0_12from Dec 7, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
any reason why you're not passing the whole context here (as opposed to individual args)? That will make things easier when you add the auth_context.
Contributor
Author
There was a problem hiding this comment.
Nice observation. I am doing this because of the way C# native interop works. If I passed the struct or pointer to the struct, I would need to redefine the same struct in C# code and make sure the memory layout of the C vs C# struct is the same. So for now, the approach I am using right now is less error-prone.
Contributor
Author
|
ping? |
Contributor
|
Sorry. I thought I had already merged this for some reason. |
jboeuf
added a commit
that referenced
this pull request
Dec 7, 2015
Introduce auth interceptor context for C#
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure future API stability with respect to #4154. (populating AuthInterceptorContext with new properties is an additive API change).