Skip to content

Use BoringSSL instead of OpenSSL#4235

Merged
murgatroid99 merged 5 commits intogrpc:release-0_12from
jcanizales:use-boringssl
Dec 3, 2015
Merged

Use BoringSSL instead of OpenSSL#4235
murgatroid99 merged 5 commits intogrpc:release-0_12from
jcanizales:use-boringssl

Conversation

@jcanizales
Copy link
Copy Markdown
Contributor

This is a prerequisite for solving #4199 (which is essentially #4121), because a dynamic framework can't be created with precompiled libraries.

It fixes #4081 and any future issue of the sort, because the BoringSSL pod works from sources.

And removes steps 6, 7, 8 and 9 from #3492, because it eliminates the 15 - 20 min of time building OpenSSL the first time one does pod install (which times out run_tests.sh). By the same token, it should speed up Travis builds considerably.

@murgatroid99
Copy link
Copy Markdown
Member

The travis build failed.

@jcanizales
Copy link
Copy Markdown
Contributor Author

It's weird, it used XCode 6.1 for those builds, instead of 7...

@jcanizales
Copy link
Copy Markdown
Contributor Author

Restarting them made them use the correct XCode and pass. The change took 10min off each of the 3 tests. Half of what remains is compiling protoc, and the other half is probably compiling OpenSSL for the test server.

murgatroid99 added a commit that referenced this pull request Dec 3, 2015
Use BoringSSL instead of OpenSSL
@murgatroid99 murgatroid99 merged commit 873d04b into grpc:release-0_12 Dec 3, 2015
@jcanizales jcanizales deleted the use-boringssl branch December 3, 2015 21:13
@jcanizales
Copy link
Copy Markdown
Contributor Author

For the record, this also fixes #4295, which happens every time OpenSSL is released and lasts O(day) until the OpenSSL podspec maintainer updates it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants