[Fixit][CI] Fix flakiness for StartsConnectingFromRandomIndex #42198
Closed
pawbhard wants to merge 1 commit into
Closed
[Fixit][CI] Fix flakiness for StartsConnectingFromRandomIndex #42198pawbhard wants to merge 1 commit into
pawbhard wants to merge 1 commit into
Conversation
rishesh007
approved these changes
Apr 22, 2026
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Apr 23, 2026
…2198) cmake/build/round_robin_test --gtest_filter=RoundRobinTest.StartsConnectingFromRandomIndex Root Cause: we have 3 index 0,1, 2 and we query to get starting index. We expect to get a random index, so test assert we get something other than 0. the probability is 1/3 we do this 10 times , so failure probability becomes (1/3)^10 approx 0.0017% . That is the reason we have not seen many instance of this failure. Increasing the loop count to 30. (This will not increase test time as we will return early as soon as we get index other than 0). This will have failure probability (1/3)^30 ~ 10^ -15 (almost impossible) Closes grpc#42198 COPYBARA_INTEGRATE_REVIEW=grpc#42198 from pawbhard:rr_flake 9a71e0b PiperOrigin-RevId: 903699099
asheshvidyut
pushed a commit
to a-detiste/grpc
that referenced
this pull request
Jun 10, 2026
…2198) cmake/build/round_robin_test --gtest_filter=RoundRobinTest.StartsConnectingFromRandomIndex Root Cause: we have 3 index 0,1, 2 and we query to get starting index. We expect to get a random index, so test assert we get something other than 0. the probability is 1/3 we do this 10 times , so failure probability becomes (1/3)^10 approx 0.0017% . That is the reason we have not seen many instance of this failure. Increasing the loop count to 30. (This will not increase test time as we will return early as soon as we get index other than 0). This will have failure probability (1/3)^30 ~ 10^ -15 (almost impossible) Closes grpc#42198 COPYBARA_INTEGRATE_REVIEW=grpc#42198 from pawbhard:rr_flake 9a71e0b PiperOrigin-RevId: 903699099
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake/build/round_robin_test --gtest_filter=RoundRobinTest.StartsConnectingFromRandomIndex
Root Cause: we have 3 index 0,1, 2 and we query to get starting index. We expect to get a random index, so test assert we get something other than 0. the probability is 1/3 we do this 10 times , so failure probability becomes (1/3)^10 approx 0.0017% . That is the reason we have not seen many instance of this failure.
Increasing the loop count to 30. (This will not increase test time as we will return early as soon as we get index other than 0). This will have failure probability (1/3)^30 ~ 10^ -15 (almost impossible)