[CI] Fix flaky prod:grpc/core/master/linux/grpc_docker_build - Add retry to ccache download#42180
Closed
asheshvidyut wants to merge 4 commits into
Closed
[CI] Fix flaky prod:grpc/core/master/linux/grpc_docker_build - Add retry to ccache download#42180asheshvidyut wants to merge 4 commits into
asheshvidyut wants to merge 4 commits into
Conversation
Contributor
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the reliability of Docker image builds by incorporating --fail and --retry flags into curl commands for ccache downloads and updates numerous Docker image versions and hashes. The review feedback recommends adding the --retry-connrefused flag to these curl commands to further mitigate transient network failures during the build process.
| # Install ccache from source since ccache 3.x packaged with most linux distributions | ||
| # does not support Redis backend for caching. | ||
| RUN curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz \ | ||
| RUN curl -sSL --fail --retry 5 -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz \ |
Contributor
There was a problem hiding this comment.
To further improve the robustness of the download against transient network issues, consider adding the --retry-connrefused flag. This ensures that curl also retries when the connection is refused, which is a common occurrence during temporary server outages or network glitches in CI environments.
RUN curl -sSL --fail --retry 5 --retry-connrefused -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz \
| # does not support Redis backend for caching. | ||
| RUN unset CMAKE_TOOLCHAIN_FILE && unset AS AR CC CPP CXX LD STRIP OBJCOPY \ | ||
| && curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz \ | ||
| && curl -sSL --fail --retry 5 -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz \ |
Contributor
There was a problem hiding this comment.
Similar to other templates, adding --retry-connrefused here would make the download more resilient to transient connection failures.
&& curl -sSL --fail --retry 5 --retry-connrefused -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz \
| # Install ccache from source since ccache 3.x packaged with most linux distributions | ||
| # does not support Redis backend for caching. | ||
| RUN curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.5.1/ccache-4.5.1.tar.gz \ | ||
| RUN curl -sSL --fail --retry 5 -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.5.1/ccache-4.5.1.tar.gz \ |
Contributor
There was a problem hiding this comment.
Consider adding --retry-connrefused to this template as well for consistent robustness across all ccache versions.
RUN curl -sSL --fail --retry 5 --retry-connrefused -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.5.1/ccache-4.5.1.tar.gz \
pawbhard
approved these changes
Apr 20, 2026
asheshvidyut
added a commit
to asheshvidyut/grpc
that referenced
this pull request
Apr 23, 2026
…try to ccache download (grpc#42180) ### Description Fix flaky tests for the log, looks like a network issue. ``` #18 [15/18] RUN curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz && tar -zxf ccache.tar.gz && cd ccache-4.11.3 && mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -DZSTD_FROM_INTERNET=ON -DHIREDIS_FROM_INTERNET=ON .. && make -j4 && make install && cd ../.. && rm -rf ccache-4.11.3 ccache.tar.gz #18 11.37 #18 11.37 gzip: stdin: not in gzip format #18 11.37 tar: Child returned status 1 #18 11.37 tar: Error is not recoverable: exiting now #18 ERROR: process "/bin/sh -c curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz && tar -zxf ccache.tar.gz && cd ccache-4.11.3 && mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -DZSTD_FROM_INTERNET=ON -DHIREDIS_FROM_INTERNET=ON .. && make -j4 && make install && cd ../.. && rm -rf ccache-4.11.3 ccache.tar.gz" did not complete successfully: exit code: 2 ------ ``` Added retry to ccache install. Closes grpc#42180 COPYBARA_INTEGRATE_REVIEW=grpc#42180 from asheshvidyut:fixit/fix-flake 33a66ed PiperOrigin-RevId: 902683742
asheshvidyut
added a commit
to a-detiste/grpc
that referenced
this pull request
Jun 10, 2026
…try to ccache download (grpc#42180) ### Description Fix flaky tests for the log, looks like a network issue. ``` grpc#18 [15/18] RUN curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz && tar -zxf ccache.tar.gz && cd ccache-4.11.3 && mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -DZSTD_FROM_INTERNET=ON -DHIREDIS_FROM_INTERNET=ON .. && make -j4 && make install && cd ../.. && rm -rf ccache-4.11.3 ccache.tar.gz grpc#18 11.37 grpc#18 11.37 gzip: stdin: not in gzip format grpc#18 11.37 tar: Child returned status 1 grpc#18 11.37 tar: Error is not recoverable: exiting now grpc#18 ERROR: process "/bin/sh -c curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.11.3/ccache-4.11.3.tar.gz && tar -zxf ccache.tar.gz && cd ccache-4.11.3 && mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -DZSTD_FROM_INTERNET=ON -DHIREDIS_FROM_INTERNET=ON .. && make -j4 && make install && cd ../.. && rm -rf ccache-4.11.3 ccache.tar.gz" did not complete successfully: exit code: 2 ------ ``` Added retry to ccache install. Closes grpc#42180 COPYBARA_INTEGRATE_REVIEW=grpc#42180 from asheshvidyut:fixit/fix-flake 33a66ed PiperOrigin-RevId: 902683742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky tests for the log, looks like a network issue.
Added retry to ccache install.