[Core CI] Make windows python distrib tests use ccache.#42171
Closed
yuanweiz wants to merge 25 commits into
Closed
[Core CI] Make windows python distrib tests use ccache.#42171yuanweiz wants to merge 25 commits into
yuanweiz wants to merge 25 commits into
Conversation
2eee020 to
1fce289
Compare
murgatroid99
approved these changes
Apr 20, 2026
sergiitk
reviewed
Apr 20, 2026
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Apr 23, 2026
Previously ccache wasn't properly enabled for our python builds before because setuptools has special logic to find MSVC and disregard `CC/CXX` flags https://github.com/pypa/setuptools/blob/main/setuptools/msvc.py. There's no graceful solution other than monkeypatching (which we already do with `_spawn_patch.py`). Certain MSVC flags are not properly handled by ccache 4.8 so we need to rewrite and exclude them from hash key generation. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#42171 COPYBARA_INTEGRATE_REVIEW=grpc#42171 from yuanweiz:fixit-windows-ccache 5ff00ca PiperOrigin-RevId: 902859436
asheshvidyut
pushed a commit
to a-detiste/grpc
that referenced
this pull request
Jun 10, 2026
Previously ccache wasn't properly enabled for our python builds before because setuptools has special logic to find MSVC and disregard `CC/CXX` flags https://github.com/pypa/setuptools/blob/main/setuptools/msvc.py. There's no graceful solution other than monkeypatching (which we already do with `_spawn_patch.py`). Certain MSVC flags are not properly handled by ccache 4.8 so we need to rewrite and exclude them from hash key generation. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#42171 COPYBARA_INTEGRATE_REVIEW=grpc#42171 from yuanweiz:fixit-windows-ccache 5ff00ca PiperOrigin-RevId: 902859436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ccache wasn't properly enabled for our python builds because setuptools has special logic to find MSVC and disregard
CC/CXXflags https://github.com/pypa/setuptools/blob/main/setuptools/msvc.py. There's no graceful solution other than monkeypatching (which we already do with_spawn_patch.py).Certain MSVC flags are not properly handled by ccache 4.8 so we need to rewrite and exclude them from hash key generation.