[Python] grpc-status: Relax protobuf dependency upper bound to allow 7.x#41948
Merged
Conversation
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies src/python/grpcio_status/setup.py by removing the upper bound for the protobuf dependency. However, this change introduces a critical syntax error due to a missing comma, which would cause incorrect string concatenation and package installation failure. Furthermore, completely removing the upper bound for protobuf is risky and could lead to breakages with future major versions; a more specific upper bound, such as <8.0.0, is recommended.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
sergiitk
approved these changes
Apr 2, 2026
sreenithi
approved these changes
Apr 22, 2026
asheshvidyut
added a commit
to asheshvidyut/grpc
that referenced
this pull request
Apr 23, 2026
…7.x (grpc#41948) ### Description Remove upper bound from `grpc-status` `setup.py` install requirement for protobuf. Fixes grpc#41933 ### Testing `cd grpc && bash test.sh` ```bash VENV_NAME=".venv_status_pb_test" python3 -m venv "$VENV_NAME" source "$VENV_NAME/bin/activate" pip install -U "protobuf>=7.0.0" pip install -U googleapis-common-protos coverage pip install -e . cd src/python/grpcio_status pip install --no-deps -e . cd ../../.. export PYTHONPATH=$(pwd)/src/python/grpcio_tests:$(pwd)/src/python/grpcio_status python3 -m unittest tests.status._grpc_status_test python3 -m unittest tests_aio.status.grpc_status_test deactivate ``` --------- Co-authored-by: Sergii Tkachenko <sergiitk@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
asheshvidyut
added a commit
to a-detiste/grpc
that referenced
this pull request
Jun 10, 2026
…7.x (grpc#41948) ### Description Remove upper bound from `grpc-status` `setup.py` install requirement for protobuf. Fixes grpc#41933 ### Testing `cd grpc && bash test.sh` ```bash VENV_NAME=".venv_status_pb_test" python3 -m venv "$VENV_NAME" source "$VENV_NAME/bin/activate" pip install -U "protobuf>=7.0.0" pip install -U googleapis-common-protos coverage pip install -e . cd src/python/grpcio_status pip install --no-deps -e . cd ../../.. export PYTHONPATH=$(pwd)/src/python/grpcio_tests:$(pwd)/src/python/grpcio_status python3 -m unittest tests.status._grpc_status_test python3 -m unittest tests_aio.status.grpc_status_test deactivate ``` --------- Co-authored-by: Sergii Tkachenko <sergiitk@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove upper bound from
grpc-statussetup.pyinstall requirement for protobuf.Fixes #41933
Testing
cd grpc && bash test.sh