[error_flatten] set status details to empty slice for OK status in v3 stack#41940
Closed
markdroth wants to merge 1 commit into
Closed
[error_flatten] set status details to empty slice for OK status in v3 stack#41940markdroth wants to merge 1 commit into
markdroth wants to merge 1 commit into
Conversation
tanvi-jagtap
approved these changes
Mar 26, 2026
tanvi-jagtap
left a comment
Collaborator
There was a problem hiding this comment.
Kokoro is also green now.
This is good.
Small optional request : Please can you copy paste the context/description from the old PR , or atleast parts of it that you find useful.
Might help.
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Mar 28, 2026
… stack (grpc#41940) It looks like this bug was introduced back in grpc#38874 when I originally implemented the error_flatten changes. I'm honestly surprised that nothing has caught this until now. Closes grpc#41940 COPYBARA_INTEGRATE_REVIEW=grpc#41940 from markdroth:error_flatten_v3_fix adaa7b0 PiperOrigin-RevId: 890647719
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Apr 8, 2026
… stack (grpc#41940) It looks like this bug was introduced back in grpc#38874 when I originally implemented the error_flatten changes. I'm honestly surprised that nothing has caught this until now. Closes grpc#41940 COPYBARA_INTEGRATE_REVIEW=grpc#41940 from markdroth:error_flatten_v3_fix adaa7b0 PiperOrigin-RevId: 890647719
asheshvidyut
pushed a commit
to a-detiste/grpc
that referenced
this pull request
Jun 10, 2026
… stack (grpc#41940) It looks like this bug was introduced back in grpc#38874 when I originally implemented the error_flatten changes. I'm honestly surprised that nothing has caught this until now. Closes grpc#41940 COPYBARA_INTEGRATE_REVIEW=grpc#41940 from markdroth:error_flatten_v3_fix adaa7b0 PiperOrigin-RevId: 890647719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this bug was introduced back in #38874 when I originally implemented the error_flatten changes. I'm honestly surprised that nothing has caught this until now.
See #41930 for context.