[Python] Docs: correct grpc.Compression references#41705
Closed
h-vetinari wants to merge 1 commit intogrpc:masterfrom
Closed
[Python] Docs: correct grpc.Compression references#41705h-vetinari wants to merge 1 commit intogrpc:masterfrom
grpc.Compression references#41705h-vetinari wants to merge 1 commit intogrpc:masterfrom
Conversation
It's either `grpc._compression` (module) or `grpc.Compression` (class).
Member
|
/gemini review |
grpc.compressiongrpc.compression
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly updates all docstrings to refer to grpc.Compression instead of grpc.compression, aligning with the actual class name. The changes are consistent across all modified files and improve the clarity and accuracy of the documentation. No further issues were found.
asheshvidyut
approved these changes
Feb 25, 2026
Member
asheshvidyut
left a comment
There was a problem hiding this comment.
Thanks for this change. LGTM.
grpc.compressiongrpc.Compression references
sergiitk
approved these changes
Feb 25, 2026
Zgoda91
pushed a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
…n` (grpc#41705) While investigating grpc#41672 I noticed some incorrect docstrings. It's either `grpc._compression` (module) or `grpc.Compression` (class), but never `grpc.compression`. Closes grpc#41705 COPYBARA_INTEGRATE_REVIEW=grpc#41705 from h-vetinari:compression 3505bd8 PiperOrigin-RevId: 875195603
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Mar 26, 2026
…n` (grpc#41705) While investigating grpc#41672 I noticed some incorrect docstrings. It's either `grpc._compression` (module) or `grpc.Compression` (class), but never `grpc.compression`. Closes grpc#41705 COPYBARA_INTEGRATE_REVIEW=grpc#41705 from h-vetinari:compression 3505bd8 PiperOrigin-RevId: 875195603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #41672 I noticed some incorrect docstrings. It's either
grpc._compression(module) orgrpc.Compression(class), but nevergrpc.compression.