[C-core] Fixed occasional segmentation fault in C-core#41630
Closed
Zgoda91 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@markdroth @ctiller PTAL |
markdroth
approved these changes
Feb 13, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/871616072](http://cl/871616072) PiperOrigin-RevId: 871616072
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
PiperOrigin-RevId: 871881944
Zgoda91
added a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
There is an occasional segmentation fault in C-core in `chttp2_transport.cc` The issue is related to non-existing `grpc_core::ExecCtx` object (NULL) during lambda destructor call. `notify_on_receive_settings` lambda-captured object might actually use `grpc_core::ExecCtx` object internally, meaning that we need to re-organize object destruction sequence a bit. Found while executing `src/python/grpcio_tests/tests_aio/unit/call_test` test suite (`test_cancel_unary_unary_in_task` test case) in a loop for 1'000 iterations. Before the fix the issue was reproducible every 100-200 test runs. After the fix was implemented I was not able to reproduce the issue after 10'000 test runs (both gLinux and vanilla Ubuntu 20.04). <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#41630 COPYBARA_INTEGRATE_REVIEW=grpc#41630 from Zgoda91:fix_for_occasional_seg_fault e5d9393 PiperOrigin-RevId: 871513750
Zgoda91
pushed a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
PiperOrigin-RevId: 871881944
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Mar 26, 2026
PiperOrigin-RevId: 871881944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an occasional segmentation fault in C-core in
chttp2_transport.ccThe issue is related to non-existing
grpc_core::ExecCtxobject (NULL) during lambda destructor call.notify_on_receive_settingslambda-captured object might actually usegrpc_core::ExecCtxobject internally, meaning that we need to re-organize object destruction sequence a bit.Found while executing
src/python/grpcio_tests/tests_aio/unit/call_testtest suite (test_cancel_unary_unary_in_tasktest case) in a loop for 1'000 iterations.Before the fix the issue was reproducible every 100-200 test runs.
After the fix was implemented I was not able to reproduce the issue after 10'000 test runs (both gLinux and vanilla Ubuntu 20.04).