Fix MSB4259 by removing whitespace in Google.Protobuf.Tools.props#41549
Open
colincmac wants to merge 1 commit intogrpc:masterfrom
Open
Fix MSB4259 by removing whitespace in Google.Protobuf.Tools.props#41549colincmac wants to merge 1 commit intogrpc:masterfrom
colincmac wants to merge 1 commit intogrpc:masterfrom
Conversation
…perty function (VS 18.5 Insiders / MSBuild) Fixes grpc#41548 Grpc.Tools 2.76.0 currently contains a property function invocation in: build/_protobuf/Google.Protobuf.Tools.props that triggers the following error: Unexpected space at position "3" of property reference "$( [System.IO.Path]::GetFullPath($(MSBuildThisFileDirectory)../../tools) )". Did you forget to remove a space? This PR removes the invalid whitespace from that property reference so that projects consuming Grpc.Tools load and build correctly under the newer MSBuild validation. Reference: dotnet/msbuild PR introducing the validation/error: dotnet/msbuild#13076
|
|
Author
|
The MSBuild changes that caused this error have been reverted as of this PR Release dotnet/dotnet#5204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41548
Grpc.Tools 2.76.0 currently contains a property function invocation in:
build/_protobuf/Google.Protobuf.Tools.props
that triggers the following error:
Unexpected space at position "3" of property reference "$( [System.IO.Path]::GetFullPath($(MSBuildThisFileDirectory)../../tools) )". Did you forget to remove a space?
This PR removes the invalid whitespace from that property reference so that projects consuming Grpc.Tools load and build correctly under the newer MSBuild validation.
Reference: dotnet/msbuild PR introducing the validation/error: dotnet/msbuild#13076