Skip to content

[xDS] add remaining polish to xDS matcher code#41500

Closed
markdroth wants to merge 33 commits intogrpc:masterfrom
markdroth:xds_matcher_polish
Closed

[xDS] add remaining polish to xDS matcher code#41500
markdroth wants to merge 33 commits intogrpc:masterfrom
markdroth:xds_matcher_polish

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Jan 28, 2026

Changes in parser:

  • add support for max recursion depth limit
  • add support for keep_matching
  • check if field is unset
  • eliminate unnecessary ParseStringMatcher() function

Changes in matcher:

  • fix edge case in XdsMatcherPrefixMap
  • add ForEachAction() method, which will be needed by composite filter
  • split matcher and matcher context into separate build targets

b/431645556
b/431645620

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Jan 28, 2026
@markdroth markdroth marked this pull request as ready for review February 2, 2026 18:10
@markdroth markdroth requested a review from pawbhard February 2, 2026 18:10
@markdroth markdroth requested a review from rishesh007 February 10, 2026 04:12
Copy link
Copy Markdown
Contributor

@rishesh007 rishesh007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markdroth markdroth deleted the xds_matcher_polish branch February 11, 2026 04:06
anniefrchz pushed a commit to anniefrchz/grpc that referenced this pull request Feb 11, 2026
Changes in parser:
- add support for max recursion depth limit
- add support for keep_matching
- check if field is unset
- eliminate unnecessary `ParseStringMatcher()` function

Changes in matcher:
- fix edge case in `XdsMatcherPrefixMap`
- add `ForEachAction()` method, which will be needed by composite filter
- split matcher and matcher context into separate build targets

b/431645556
b/431645620

Closes grpc#41500

COPYBARA_INTEGRATE_REVIEW=grpc#41500 from markdroth:xds_matcher_polish f41a36e
PiperOrigin-RevId: 868440217
Zgoda91 pushed a commit to Zgoda91/grpc that referenced this pull request Mar 22, 2026
Changes in parser:
- add support for max recursion depth limit
- add support for keep_matching
- check if field is unset
- eliminate unnecessary `ParseStringMatcher()` function

Changes in matcher:
- fix edge case in `XdsMatcherPrefixMap`
- add `ForEachAction()` method, which will be needed by composite filter
- split matcher and matcher context into separate build targets

b/431645556
b/431645620

Closes grpc#41500

COPYBARA_INTEGRATE_REVIEW=grpc#41500 from markdroth:xds_matcher_polish f41a36e
PiperOrigin-RevId: 868440217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/low lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants