[Python] Update setuptools min version to 77.0.1 #40931
Closed
sreenithi wants to merge 6 commits intogrpc:masterfrom
Closed
[Python] Update setuptools min version to 77.0.1 #40931sreenithi wants to merge 6 commits intogrpc:masterfrom
sreenithi wants to merge 6 commits intogrpc:masterfrom
Conversation
sergiitk
reviewed
Oct 21, 2025
sergiitk
reviewed
Oct 22, 2025
src/python/grpcio/commands.py
Outdated
|
|
||
| def build_extensions(self): | ||
|
|
||
| use_short_temp = os.environ.get("GRPC_USE_SHORT_BUILD_TEMP", 0) |
Member
There was a problem hiding this comment.
we should use something but more discrete
Suggested change
| use_short_temp = os.environ.get("GRPC_USE_SHORT_BUILD_TEMP", 0) | |
| use_short_temp = os.environ.get("GRPC_PYTHON_BUILD_USE_SHORT_TEMP_DIR_NAME", 0) |
src/python/grpcio/commands.py
Outdated
| def build_extensions(self): | ||
|
|
||
| use_short_temp = os.environ.get("GRPC_USE_SHORT_BUILD_TEMP", 0) | ||
| if use_short_temp: |
Member
There was a problem hiding this comment.
Note that when the env var explicitly is set to 0, it'll be parsed as string "0", which means this condition is resolved to true. Instead, do
Suggested change
| if use_short_temp: | |
| if use_short_temp == "1": |
In [2]: "0" or 123
Out[2]: '0'
In [3]: 0 or 123
Out[3]: 123
In [4]: bool("0")
Out[4]: True
In [5]: bool("")
Out[5]: False
Contributor
Author
There was a problem hiding this comment.
oh good catch, thanks. I had only considered setting to 1 and leaving it unset, but hadn't considered the case for setting the value to '0'. Changed now.
sergiitk
approved these changes
Oct 22, 2025
Member
sergiitk
left a comment
There was a problem hiding this comment.
LGTM for export, but please address the feedback
sreenithi
added a commit
to sreenithi/grpc
that referenced
this pull request
Oct 24, 2025
This PR updates the minimum version of `setuptools` package required across different Python setup files to v77.0.1. This version contains Python 3.14 support as well as deprecates a format for defining project license in `pyproject.toml` files ([Reference](https://setuptools.pypa.io/en/stable/history.html#id71)) which is a prerequisite for grpc#40833 Closes grpc#40931 PiperOrigin-RevId: 823008815
sergiitk
reviewed
Oct 24, 2025
Member
sergiitk
left a comment
There was a problem hiding this comment.
Great job addressing my feedback, thank you!
sergiitk
pushed a commit
that referenced
this pull request
Oct 27, 2025
…40953) Backport of #40931 to v1.76.x. --- This PR updates the minimum version of `setuptools` package required across different Python setup files to v77.0.1. This version contains Python 3.14 support as well as deprecates a format for defining project license in `pyproject.toml` files ([Reference](https://setuptools.pypa.io/en/stable/history.html#id71)) which is a prerequisite for #40833
sreenithi
added a commit
to sreenithi/grpc
that referenced
this pull request
Nov 26, 2025
This PR updates the minimum version of `setuptools` package required across different Python setup files to v77.0.1. This version contains Python 3.14 support as well as deprecates a format for defining project license in `pyproject.toml` files ([Reference](https://setuptools.pypa.io/en/stable/history.html#id71)) which is a prerequisite for grpc#40833 Closes grpc#40931 PiperOrigin-RevId: 823008815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the minimum version of
setuptoolspackage required across different Python setup files to v77.0.1. This version contains Python 3.14 support as well as deprecates a format for defining project license inpyproject.tomlfiles (Reference) which is a prerequisite for #40833