[Python] Log error details when ExecuteBatchError occurs (at DEBUG level)#40921
[Python] Log error details when ExecuteBatchError occurs (at DEBUG level)#40921chandra-siri wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
sergiitk
left a comment
There was a problem hiding this comment.
I'm OK with this change overall.
@chandra-siri: Were you able to test this code path, manually of otherwise? Could you please share a sample of the final log message produce?
|
LGTM as well. I've re-triggered the Python and sanity tests as they seemed to be flaky failures |
yes, I was able to test the code path. Here's the output sample. also attached the image. |
|
Not sure why any idea @sergiitk , @sreenithi ? |
|
oh nothing to worry, that's the way our process works. Your changes were submitted in this commit by copybara and the PR is closed. Your changes are now live in master: https://github.com/grpc/grpc/blob/master/src/python/grpcio/grpc/_cython/_cygrpc/aio/callback_common.pyx.pxi#L133 |
…vel) (grpc#40921) Log error details when `ExecuteBatchError` occurs. The error is logged with DEBUG severity level. Message example: > `Failed to receive any message from Core: Failed grpc_call_start_batch: 8 with grpc_call_error value: 'GRPC_CALL_ERROR_TOO_MANY_OPERATIONS` Closes grpc#40921 COPYBARA_INTEGRATE_REVIEW=grpc#40921 from chandra-siri:log_exception_details 316de3d PiperOrigin-RevId: 823347363
Log error details when
ExecuteBatchErroroccurs. The error is logged with DEBUG severity level. Message example: