Closed
Conversation
ctiller
approved these changes
Aug 21, 2025
Member
ctiller
left a comment
There was a problem hiding this comment.
I don't understand the race or the fix, but this seems like reasonable code.
Member
Author
|
Basically, the picker was directly accessing the |
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Aug 22, 2025
Fixes a TSAN race accidentally introduced in grpc#40486. b/440289448 Closes grpc#40517 COPYBARA_INTEGRATE_REVIEW=grpc#40517 from markdroth:metrics_backend_service_label_tsan_fix 7b8291e PiperOrigin-RevId: 797943490
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
Fixes a TSAN race accidentally introduced in grpc#40486. b/440289448 Closes grpc#40517 COPYBARA_INTEGRATE_REVIEW=grpc#40517 from markdroth:metrics_backend_service_label_tsan_fix 7b8291e PiperOrigin-RevId: 797943490
anniefrchz
pushed a commit
to anniefrchz/grpc
that referenced
this pull request
Sep 3, 2025
Fixes a TSAN race accidentally introduced in grpc#40486. b/440289448 Closes grpc#40517 COPYBARA_INTEGRATE_REVIEW=grpc#40517 from markdroth:metrics_backend_service_label_tsan_fix 7b8291e PiperOrigin-RevId: 797943490
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Sep 12, 2025
Fixes a TSAN race accidentally introduced in grpc#40486. b/440289448 Closes grpc#40517 COPYBARA_INTEGRATE_REVIEW=grpc#40517 from markdroth:metrics_backend_service_label_tsan_fix 7b8291e PiperOrigin-RevId: 797943490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a TSAN race accidentally introduced in #40486.
b/440289448