[Security] Spiffe Verification roll forward#40476
Closed
gtcooke94 wants to merge 7 commits intogrpc:masterfrom
Closed
[Security] Spiffe Verification roll forward#40476gtcooke94 wants to merge 7 commits intogrpc:masterfrom
gtcooke94 wants to merge 7 commits intogrpc:masterfrom
Conversation
Automated fix for refs/heads/spiffe_roll_forward
matthewstevenson88
approved these changes
Aug 18, 2025
gtcooke94
added a commit
to gtcooke94/grpc
that referenced
this pull request
Aug 21, 2025
Roll forward grpc#40321 with fixes relating to OpenSSL 1.0.2 This roll forward fixes two things broken by the original commit: * OpenSSL 1.0.2 compatibility - `X509_up_ref` is not in 1.0.2, so `CRYPTO_add` is used along with compiler directives. * The macOS tests flatten trust bundles, and two files in different directories were both named `ca.pem` in the new `spiffe_bundle_map_end2end_test.cc`. One was from the existing test that this new test file was modeled after and was not needed, so it was removed from the BUILD file resolving the double naming conflict. Closes grpc#40476 COPYBARA_INTEGRATE_REVIEW=grpc#40476 from gtcooke94:spiffe_roll_forward e30b7e4 PiperOrigin-RevId: 796537764
gtcooke94
added a commit
that referenced
this pull request
Aug 21, 2025
Cherry pick #40476 to 1.75 RELEASE NOTES: * Adds support for SPIFFE Bundle Maps in as roots of trust per [gRFC A87](https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md) and grpc/proposal#506
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Aug 22, 2025
Roll forward grpc#40321 with fixes relating to OpenSSL 1.0.2 This roll forward fixes two things broken by the original commit: * OpenSSL 1.0.2 compatibility - `X509_up_ref` is not in 1.0.2, so `CRYPTO_add` is used along with compiler directives. * The macOS tests flatten trust bundles, and two files in different directories were both named `ca.pem` in the new `spiffe_bundle_map_end2end_test.cc`. One was from the existing test that this new test file was modeled after and was not needed, so it was removed from the BUILD file resolving the double naming conflict. Closes grpc#40476 COPYBARA_INTEGRATE_REVIEW=grpc#40476 from gtcooke94:spiffe_roll_forward e30b7e4 PiperOrigin-RevId: 796537764
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
Roll forward grpc#40321 with fixes relating to OpenSSL 1.0.2 This roll forward fixes two things broken by the original commit: * OpenSSL 1.0.2 compatibility - `X509_up_ref` is not in 1.0.2, so `CRYPTO_add` is used along with compiler directives. * The macOS tests flatten trust bundles, and two files in different directories were both named `ca.pem` in the new `spiffe_bundle_map_end2end_test.cc`. One was from the existing test that this new test file was modeled after and was not needed, so it was removed from the BUILD file resolving the double naming conflict. Closes grpc#40476 COPYBARA_INTEGRATE_REVIEW=grpc#40476 from gtcooke94:spiffe_roll_forward e30b7e4 PiperOrigin-RevId: 796537764
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Sep 12, 2025
Roll forward grpc#40321 with fixes relating to OpenSSL 1.0.2 This roll forward fixes two things broken by the original commit: * OpenSSL 1.0.2 compatibility - `X509_up_ref` is not in 1.0.2, so `CRYPTO_add` is used along with compiler directives. * The macOS tests flatten trust bundles, and two files in different directories were both named `ca.pem` in the new `spiffe_bundle_map_end2end_test.cc`. One was from the existing test that this new test file was modeled after and was not needed, so it was removed from the BUILD file resolving the double naming conflict. Closes grpc#40476 COPYBARA_INTEGRATE_REVIEW=grpc#40476 from gtcooke94:spiffe_roll_forward e30b7e4 PiperOrigin-RevId: 796537764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roll forward #40321 with fixes relating to OpenSSL 1.0.2
This roll forward fixes two things broken by the original commit:
X509_up_refis not in 1.0.2, soCRYPTO_addis used along with compiler directives.ca.pemin the newspiffe_bundle_map_end2end_test.cc. One was from the existing test that this new test file was modeled after and was not needed, so it was removed from the BUILD file resolving the double naming conflict.