Fix max sockaddr struct size on OpenBSD#40454
Closed
brad0 wants to merge 1 commit intogrpc:masterfrom
Closed
Conversation
Contributor
Author
|
Ping. |
Contributor
Author
|
Ping. |
1 similar comment
Contributor
Author
|
Ping. |
Contributor
Author
|
@markdroth Ping. |
Contributor
Author
|
What magic incantations do I need to do to get this reviewed? |
murgatroid99
requested changes
Feb 25, 2026
Member
murgatroid99
left a comment
There was a problem hiding this comment.
Our standard for handling platform differences like this is to handle those checks in port_platform.h. A constant should be defined there, and these files should just reference it.
e3bb5e9 to
7012674
Compare
Contributor
Author
Thanks. That makes a lot more sense and is cleaner. |
murgatroid99
requested changes
Feb 25, 2026
| #endif | ||
| #endif | ||
|
|
||
| #ifndef GRPC_MAX_SOCKADDR_SIZE |
Member
There was a problem hiding this comment.
It would be more consistent with the rest of the file to write the following here, and remove the other change:
#ifdef GPR_OPENBSD
#define GRPC_MAX_SOCKADDR_SIZE 256
#else
#define GRPC_MAX_SOCKADDR_SIZE 128
#endifMove the definition of GRPC_MAX_SOCKADDR_SIZE over to port_platform.h and override the value for OpenBSD.
7012674 to
a29f029
Compare
murgatroid99
approved these changes
Feb 25, 2026
markdroth
approved these changes
Feb 26, 2026
Zgoda91
pushed a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
Closes grpc#40454 COPYBARA_INTEGRATE_REVIEW=grpc#40454 from brad0:max_struct_openbsd a29f029 PiperOrigin-RevId: 876346213
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Mar 26, 2026
Closes grpc#40454 COPYBARA_INTEGRATE_REVIEW=grpc#40454 from brad0:max_struct_openbsd a29f029 PiperOrigin-RevId: 876346213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.