Ruby: Mark credential object in channel#40394
Closed
rwstauner wants to merge 1 commit intogrpc:masterfrom
Closed
Conversation
e599c3d to
48c11d4
Compare
apolcyn
approved these changes
Aug 5, 2025
Contributor
|
@rwstauner can you please apply the patch in #40395 ? We will need that for sanity checks to pass |
The credentials object potentially holds a reference to a proc when composed with CallCredentials. We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel. Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com> Co-authored-by: Peter Zhu <peter.zhu@shopify.com> Co-authored-by: Kevin Menard <kevin.menard@shopify.com>
48c11d4 to
d1d58eb
Compare
stanley-cheung
approved these changes
Aug 6, 2025
apolcyn
pushed a commit
to apolcyn/grpc
that referenced
this pull request
Aug 6, 2025
The credentials object potentially holds a reference to a proc when composed with CallCredentials. We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel. This addresses grpc#40368 Closes grpc#40394 COPYBARA_INTEGRATE_REVIEW=grpc#40394 from Shopify:rwstauner/mark-channel-creds d1d58eb PiperOrigin-RevId: 791494166
apolcyn
added a commit
that referenced
this pull request
Aug 6, 2025
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Aug 11, 2025
The credentials object potentially holds a reference to a proc when composed with CallCredentials. We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel. This addresses grpc#40368 Closes grpc#40394 COPYBARA_INTEGRATE_REVIEW=grpc#40394 from Shopify:rwstauner/mark-channel-creds d1d58eb PiperOrigin-RevId: 791494166
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
The credentials object potentially holds a reference to a proc when composed with CallCredentials. We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel. This addresses grpc#40368 Closes grpc#40394 COPYBARA_INTEGRATE_REVIEW=grpc#40394 from Shopify:rwstauner/mark-channel-creds d1d58eb PiperOrigin-RevId: 791494166
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Sep 12, 2025
The credentials object potentially holds a reference to a proc when composed with CallCredentials. We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel. This addresses grpc#40368 Closes grpc#40394 COPYBARA_INTEGRATE_REVIEW=grpc#40394 from Shopify:rwstauner/mark-channel-creds d1d58eb PiperOrigin-RevId: 791494166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credentials object potentially holds a reference to a proc when composed with CallCredentials.
We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel.
This addresses #40368