Add language features to exported proto files#40377
Closed
mkruskal-google wants to merge 4 commits intogrpc:masterfrom
Closed
Add language features to exported proto files#40377mkruskal-google wants to merge 4 commits intogrpc:masterfrom
mkruskal-google wants to merge 4 commits intogrpc:masterfrom
Conversation
drfloob
approved these changes
Aug 4, 2025
Member
drfloob
left a comment
There was a problem hiding this comment.
This looks ok to me. @sreenithi PTAL as well.
Contributor
Author
|
Whoops, thanks for the pointer @sreenithi! PTAL at update |
sreenithi
reviewed
Aug 5, 2025
sreenithi
approved these changes
Aug 5, 2025
Contributor
|
looks like these changes alone are also not enough, and is causing most of the Python CI tests to fail. please look into it too. |
Contributor
Author
|
@sreenithi This should fix it as best I can tell with local runs, can you rerun presubmits? |
These need to be available to build editions protos
482ccbe to
c2d21d4
Compare
Member
|
Hey @mkruskal-google , We took your commits ahead and created a new PR. Added some tests on top of that and merged it. Hence closing this PR. Hope its fine. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These need to be available to build editions protos