[Python] Fixes issue 40325 - grpcio fails to install on all non-Mac Apple devices internal builds#40347
Closed
asheshvidyut wants to merge 2 commits intogrpc:masterfrom
Closed
[Python] Fixes issue 40325 - grpcio fails to install on all non-Mac Apple devices internal builds#40347asheshvidyut wants to merge 2 commits intogrpc:masterfrom
asheshvidyut wants to merge 2 commits intogrpc:masterfrom
Conversation
sreenithi
reviewed
Jul 29, 2025
Comment on lines
+165
to
+168
| < ( | ||
| 10, | ||
| 14, | ||
| ) |
Contributor
There was a problem hiding this comment.
can't this be fit into the same line now? It was previously split by black into multiple lines because of the 80 character limit I believe, but I think that shouldn't be needed now.
Member
Author
There was a problem hiding this comment.
This was done by black.
Member
There was a problem hiding this comment.
We should be breaking it up into separate variables to make it readable. Black producing unreadable code is a hint you need to refactor. Something like this
def macos_target_ver():
target_ver = sysconfig.get_config_var("MACOSX_DEPLOYMENT_TARGET")
if target_ver is None or target_ver == "":
return tuple()
return tuple(int(p) for p in target_ver.split("."))
if sys.platform == "darwin":
if "MACOSX_DEPLOYMENT_TARGET" not in os.environ:
target_ver = macos_target_ver()
if target_ver and target_ver < (10, 14):
os.environ["MACOSX_DEPLOYMENT_TARGET"] = "11.0"
sreenithi
approved these changes
Jul 29, 2025
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Aug 11, 2025
### Description Fixes grpc#40325 Closes grpc#40347 COPYBARA_INTEGRATE_REVIEW=grpc#40347 from asheshvidyut:fix/issue-40325 4a22fb4 PiperOrigin-RevId: 788705992
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
### Description Fixes grpc#40325 Closes grpc#40347 COPYBARA_INTEGRATE_REVIEW=grpc#40347 from asheshvidyut:fix/issue-40325 4a22fb4 PiperOrigin-RevId: 788705992
asheshvidyut
added a commit
to asheshvidyut/grpc
that referenced
this pull request
Sep 12, 2025
### Description Fixes grpc#40325 Closes grpc#40347 COPYBARA_INTEGRATE_REVIEW=grpc#40347 from asheshvidyut:fix/issue-40325 4a22fb4 PiperOrigin-RevId: 788705992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #40325