Skip to content

[ci] Use Black 24.8.0#40256

Closed
eugeneo wants to merge 1 commit intomasterfrom
eugeneo-rollback-black
Closed

[ci] Use Black 24.8.0#40256
eugeneo wants to merge 1 commit intomasterfrom
eugeneo-rollback-black

Conversation

@eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jul 18, 2025

Python 3.8 can't use 25.1 - failure.

@eugeneo eugeneo requested a review from sergiitk July 18, 2025 21:18
@eugeneo eugeneo added the release notes: no Indicates if PR should not be in release notes label Jul 18, 2025
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not support python3.8 anymore. #40139 should take care of the last remnants of old python versions, but there's a few failing tests I'm working on right now.
If we can't wait with fixing the PRAutoFix action, let's bump the python version in the action config instead:

https://github.com/grpc/grpc/pull/40139/files#diff-af1d41aa37eb062fa597ab204301c50e808102faf3b257e98b8a87d1cb04e813

https://github.com/sergiitk/grpc/blob/feat/py39/grpc_python_bazel_test/.github/workflows/pr-auto-fix.yaml#L67-L71

@eugeneo eugeneo closed this Jul 18, 2025
@eugeneo eugeneo deleted the eugeneo-rollback-black branch July 18, 2025 21:27
sergiitk added a commit that referenced this pull request Jul 22, 2025
Previously broken by requiring black version that dropped py3.8 support.
Gitignore/dockerignore changes made to prevent ruff checking virtualenv
directories.

Related:
- #40256 
- #40139
asheshvidyut pushed a commit to asheshvidyut/grpc that referenced this pull request Jul 28, 2025
Previously broken by requiring black version that dropped py3.8 support.
Gitignore/dockerignore changes made to prevent ruff checking virtualenv
directories.

Related:
- grpc#40256 
- grpc#40139
paulosjca pushed a commit to paulosjca/grpc that referenced this pull request Aug 23, 2025
Previously broken by requiring black version that dropped py3.8 support.
Gitignore/dockerignore changes made to prevent ruff checking virtualenv
directories.

Related:
- grpc#40256 
- grpc#40139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants