Skip to content

[CI] Bump pylint to 2.17.7#40169

Closed
sergiitk wants to merge 7 commits intogrpc:masterfrom
sergiitk:feat/py39/upgrade-pylint
Closed

[CI] Bump pylint to 2.17.7#40169
sergiitk wants to merge 7 commits intogrpc:masterfrom
sergiitk:feat/py39/upgrade-pylint

Conversation

@sergiitk
Copy link
Member

@sergiitk sergiitk commented Jul 11, 2025

In preparation for migrating it from python3.7 to python3.11.
Pylint version had to be upgraded because pylint==2.2.2 doesn't support python 3.11.

The image will be updated separately to remove compiling python3.7 from source in #40139.

Pylint v2.17.7 docs: https://pylint.readthedocs.io/en/v2.17.7

@sergiitk sergiitk requested a review from asheshvidyut July 11, 2025 08:32
@sergiitk sergiitk added the release notes: no Indicates if PR should not be in release notes label Jul 11, 2025
locally-disabled,
# NOTE(nathaniel): What even is this? *Enabling* an inspection results
# in a warning? How does that encourage more analysis and coverage?
locally-enabled,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asheshvidyut Removed a few of previously disabled checks because they were dropped by pylint itself.

@@ -1,4 +1,9 @@
[MASTER]
[MAIN]
load-plugins=
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asheshvidyut and this was needed because some checks were moved to plugins.

Copy link
Member

@asheshvidyut asheshvidyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@sergiitk sergiitk deleted the feat/py39/upgrade-pylint branch July 14, 2025 20:55
@sergiitk
Copy link
Member Author

Fixes #23394.

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request Aug 23, 2025
In preparation for migrating it from python3.7 to python3.11.
Pylint version had to be upgraded because pylint==2.2.2 doesn't support python 3.11.

The image will be updated separately to remove compiling python3.7 from source in grpc#40139.

Pylint v2.17.7 docs: https://pylint.readthedocs.io/en/v2.17.7

Closes grpc#40169

PiperOrigin-RevId: 783026287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants