Skip to content

[Python] Add typing-extensions dependency#40137

Closed
sergiitk wants to merge 9 commits intogrpc:masterfrom
sergiitk:deps/py/typing-extensions
Closed

[Python] Add typing-extensions dependency#40137
sergiitk wants to merge 9 commits intogrpc:masterfrom
sergiitk:deps/py/typing-extensions

Conversation

@sergiitk
Copy link
Member

@sergiitk sergiitk commented Jul 8, 2025

@sergiitk sergiitk force-pushed the deps/py/typing-extensions branch from 43e8d7e to bfb1bbb Compare July 10, 2025 22:54
@sergiitk sergiitk requested a review from asheshvidyut July 11, 2025 01:44
@sergiitk sergiitk marked this pull request as ready for review July 11, 2025 02:44
@sergiitk sergiitk requested a review from veblush as a code owner July 11, 2025 02:44
Copy link
Member

@asheshvidyut asheshvidyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just to mention - We could use https://pypi.org/project/typing-extensions/4.14.1/ -> since it supports Python >= 3.9. but I think now we run tests in 3.8 so it's fine.

Maybe we can bump the version later.

@sergiitk
Copy link
Member Author

sergiitk commented Jul 11, 2025

@asheshvidyut yea, I started with 4.14.1, but had to downgrade to 4.13.2 (b50f1a7) because some of our CIs are still running pre-3.9 python.

I'm upgrading CIs to 3.9+ in #40139, will bump typing extensions once it's merged.

@sergiitk
Copy link
Member Author

Failed kokoro run is a part of
https://source.cloud.google.com/results/invocations/4e275d08-6489-4ec3-880a-d948f47d4df6. Looks like prod:grpc/core/master/linux/release/grpc_collect_all_packages job doesn't allow overriding GH to a fork.

However, one of the jobs that do matter failed:

@sergiitk
Copy link
Member Author

The job that failed is windows/release/grpc_distribtests_python. I think for the same reason we've seen recently, the one @sreenithi is investigating.

@sergiitk sergiitk deleted the deps/py/typing-extensions branch July 16, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants