Skip to content

Fix compile: check return value for error#4

Merged
yang-g merged 1 commit intogrpc:masterfrom
ctiller:vasprint
Jan 13, 2015
Merged

Fix compile: check return value for error#4
yang-g merged 1 commit intogrpc:masterfrom
ctiller:vasprint

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Jan 12, 2015

No description provided.

yang-g added a commit that referenced this pull request Jan 13, 2015
Fix compile: check return value for error
@yang-g yang-g merged commit d8532af into grpc:master Jan 13, 2015
@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 13, 2015

Don't do that again until we're done with Piper (please).

I'll send out a CL in the morning to rectify this Nico.
On Mon Jan 12 2015 at 9:58:09 PM yang-g notifications@github.com wrote:

Merged #4 #4.


Reply to this email directly or view it on GitHub
#4 (comment).

@yang-g
Copy link
Copy Markdown
Contributor

yang-g commented Jan 13, 2015

OK.

On Mon, Jan 12, 2015 at 10:15 PM, Craig Tiller notifications@github.com
wrote:

Don't do that again until we're done with Piper (please).

I'll send out a CL in the morning to rectify this Nico.
On Mon Jan 12 2015 at 9:58:09 PM yang-g notifications@github.com wrote:

Merged #4 #4.


Reply to this email directly or view it on GitHub
#4 (comment).


Reply to this email directly or view it on GitHub
#4 (comment).

@nicolasnoble
Copy link
Copy Markdown
Contributor

Aren't we done with piper ? :-) At that point, this could mark our first plain-github commit.

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 13, 2015

Let's check the state of things in the morning.

On Mon, Jan 12, 2015, 22:32 Nicolas Noble notifications@github.com wrote:

Aren't we done with piper ? :-) At that point, this could mark our first
plain-github commit.


Reply to this email directly or view it on GitHub
#4 (comment).

@ctiller ctiller deleted the vasprint branch January 16, 2015 23:22
@yang-g yang-g mentioned this pull request Feb 10, 2015
ctiller added a commit that referenced this pull request Mar 7, 2015
Don't merge OpenSSL into C++ upper layer libraries; only C.
nicolasnoble added a commit that referenced this pull request Jun 17, 2015
…mplate

Fixed file renaming in podspec template
muxi added a commit that referenced this pull request Jan 25, 2018
…ility

Update ruby extension to compression changes
matt-kwong added a commit that referenced this pull request Jan 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
@veblush veblush added the release notes: no Indicates if PR should not be in release notes label Jun 21, 2019
lidizheng referenced this pull request in lidizheng/grpc Feb 12, 2021
#54)

* Support templated variables following the HTTP access log format and
  capabilities.

* Suppport specifying append/override behavior.

* Add some TLS variables to the HTTP access log format specifier list.
  (see
  https://lyft.github.io/envoy/docs/configuration/http_conn_man/access_log.html
  for the original).

Fixes #4.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants