[Revert] "[ruby] Build/test ruby 3.4 and build native gems with Ruby 3.4 support"#38516
Closed
stanley-cheung wants to merge 1 commit intogrpc:masterfrom
Closed
[Revert] "[ruby] Build/test ruby 3.4 and build native gems with Ruby 3.4 support"#38516stanley-cheung wants to merge 1 commit intogrpc:masterfrom
stanley-cheung wants to merge 1 commit intogrpc:masterfrom
Conversation
… gems wi…" This reverts commit ab2222d.
eugeneo
approved these changes
Jan 22, 2025
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Jan 23, 2025
…3.4 support" (grpc#38516) This reverts grpc#38338 as it's breaking the `prod:grpc/core/master/linux/release/grpc_distribtests_ruby` job as part of the release process Closes grpc#38516 PiperOrigin-RevId: 718431575
apolcyn
added a commit
to apolcyn/grpc
that referenced
this pull request
Jan 28, 2025
…th Ruby 3.4 support" (grpc#38516)" This reverts commit 1af9b68.
XuanWang-Amos
pushed a commit
to xrmx/grpc
that referenced
this pull request
Jan 28, 2025
…3.4 support" (grpc#38516) This reverts grpc#38338 as it's breaking the `prod:grpc/core/master/linux/release/grpc_distribtests_ruby` job as part of the release process Closes grpc#38516 PiperOrigin-RevId: 718431575
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
…t (REDUX) (#38601) Repeat attempt of #38338 to bring Ruby 3.4 precompiled gems to grpc. Pending #38597 Brief history - #38338 merged - #38458 backported to 1.70.x and merged - Above two changes reverted in #38516 and #38515 due to release urgency. Root cause was minor artifact build timeout due to release infra having smaller hosts (fixed in #38597) - Discussion in #38487 about adding back the workaround with `RUBY_PATCHLEVEL`. Unclear if necessary. This PR - cherry-picks the original squashed PR - adds back the `RUBY_PATCHLEVEL` hack, per discussion in #38487 - further upgrades `rake-compiler-dock` to `1.9.1` which avoids coupling patch versions between grpc and rake-compiler-dock - This version changes the host Ruby version from `3.1` -> `3.4` so _technically_ we _could_ validate the theory from #38487. Will await @apolcyn advice. Needs rake-compiler-dock test image re-uploads courtesy of @apolcyn 🙏 Closes #38601 PiperOrigin-RevId: 720824180
chadlwilson
added a commit
to chadlwilson/grpc
that referenced
this pull request
Jan 29, 2025
…t (REDUX) (grpc#38601) Repeat attempt of grpc#38338 to bring Ruby 3.4 precompiled gems to grpc. Pending grpc#38597 Brief history - grpc#38338 merged - grpc#38458 backported to 1.70.x and merged - Above two changes reverted in grpc#38516 and grpc#38515 due to release urgency. Root cause was minor artifact build timeout due to release infra having smaller hosts (fixed in grpc#38597) - Discussion in grpc#38487 about adding back the workaround with `RUBY_PATCHLEVEL`. Unclear if necessary. This PR - cherry-picks the original squashed PR - adds back the `RUBY_PATCHLEVEL` hack, per discussion in grpc#38487 - further upgrades `rake-compiler-dock` to `1.9.1` which avoids coupling patch versions between grpc and rake-compiler-dock - This version changes the host Ruby version from `3.1` -> `3.4` so _technically_ we _could_ validate the theory from grpc#38487. Will await @apolcyn advice. Needs rake-compiler-dock test image re-uploads courtesy of @apolcyn 🙏 Closes grpc#38601 PiperOrigin-RevId: 720824180 (cherry picked from commit ef13727)
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Feb 20, 2025
…3.4 support" (grpc#38516) This reverts grpc#38338 as it's breaking the `prod:grpc/core/master/linux/release/grpc_distribtests_ruby` job as part of the release process Closes grpc#38516 PiperOrigin-RevId: 718431575
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Feb 20, 2025
…t (REDUX) (grpc#38601) Repeat attempt of grpc#38338 to bring Ruby 3.4 precompiled gems to grpc. Pending grpc#38597 Brief history - grpc#38338 merged - grpc#38458 backported to 1.70.x and merged - Above two changes reverted in grpc#38516 and grpc#38515 due to release urgency. Root cause was minor artifact build timeout due to release infra having smaller hosts (fixed in grpc#38597) - Discussion in grpc#38487 about adding back the workaround with `RUBY_PATCHLEVEL`. Unclear if necessary. This PR - cherry-picks the original squashed PR - adds back the `RUBY_PATCHLEVEL` hack, per discussion in grpc#38487 - further upgrades `rake-compiler-dock` to `1.9.1` which avoids coupling patch versions between grpc and rake-compiler-dock - This version changes the host Ruby version from `3.1` -> `3.4` so _technically_ we _could_ validate the theory from grpc#38487. Will await @apolcyn advice. Needs rake-compiler-dock test image re-uploads courtesy of @apolcyn 🙏 Closes grpc#38601 PiperOrigin-RevId: 720824180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #38338 as it's breaking the
prod:grpc/core/master/linux/release/grpc_distribtests_rubyjob as part of the release process