Skip to content

[OTel C++] Add tracing support#38437

Closed
yashykt wants to merge 35 commits intogrpc:masterfrom
yashykt:OpenTelemetryTracing
Closed

[OTel C++] Add tracing support#38437
yashykt wants to merge 35 commits intogrpc:masterfrom
yashykt:OpenTelemetryTracing

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Jan 11, 2025 •
edited by markdroth
Loading

As per gRFC A72.

@yashykt yashykt marked this pull request as ready for review January 11, 2025 02:29
@yashykt yashykt requested a review from markdroth January 11, 2025 02:29
@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Jan 11, 2025
This was referenced Feb 12, 2025
Closed
Closed
markdroth
markdroth reviewed Feb 20, 2025
View reviewed changes
copybara-service bot pushed a commit that referenced this pull request Feb 21, 2025
@yashykt @copybara-github
[CallAttemptTracer] Fix call attempt tracer lifetimes for retries (#3…
211f9ec 
…8729)

Fix #38728 heap-use-after-free. Details in the issue.

Also, fix a bug in chttp2 where we are using the parent call tracer instead of the call attempt tracer to record annotations for a stream.

Test is being added in #38437

Closes #38729

COPYBARA_INTEGRATE_REVIEW=#38729 from yashykt:FixCallAttemptTracer cb09add
PiperOrigin-RevId: 729307540
yashykt added a commit to yashykt/grpc that referenced this pull request Feb 21, 2025
@yashykt
[CallAttemptTracer] Fix call attempt tracer lifetimes for retries (gr…
e60dfce 
…pc#38729)

Fix grpc#38728 heap-use-after-free. Details in the issue.

Also, fix a bug in chttp2 where we are using the parent call tracer instead of the call attempt tracer to record annotations for a stream.

Test is being added in grpc#38437

Closes grpc#38729

COPYBARA_INTEGRATE_REVIEW=grpc#38729 from yashykt:FixCallAttemptTracer cb09add
PiperOrigin-RevId: 729307540
markdroth
markdroth approved these changes Feb 21, 2025
View reviewed changes
yashykt added a commit to yashykt/grpc that referenced this pull request Feb 24, 2025
@yashykt
Revert "[OTel C++] Add tracing support (grpc#38437)"
74abeb8 
This reverts commit a6eb776.
copybara-service bot pushed a commit that referenced this pull request Feb 25, 2025
@yashykt @copybara-github
Revert "[OTel C++] Add tracing support (#38437)" (#38821)
ca0d85c 
This reverts commit a6eb776.

Looks like the TransparentRetries test is flaky

Closes #38821

COPYBARA_INTEGRATE_REVIEW=#38821 from yashykt:RevertOTelTracing 74abeb8
PiperOrigin-RevId: 730800878
yashykt added a commit to yashykt/grpc that referenced this pull request Feb 26, 2025
@yashykt
Reapply "[OTel C++] Add tracing support (grpc#38437)" (grpc#38821)
395b31f 
This reverts commit ca0d85c.
yashykt added a commit to yashykt/grpc that referenced this pull request Feb 26, 2025
@yashykt
Reapply "[OTel C++] Add tracing support (grpc#38437)" (grpc#38821)
4563d7e 
This reverts commit ca0d85c.
@yashykt yashykt mentioned this pull request Feb 26, 2025
Closed
@yashykt yashykt added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Feb 26, 2025
copybara-service bot pushed a commit that referenced this pull request Feb 28, 2025
@yashykt @copybara-github
[OTel C++] Reland OTel C++ Tracing (#38852)
ac0eed3 
Reland #38437. Contains fix for the TransparentRetry flaky test. Verified with 10000 runs.

Closes #38852

COPYBARA_INTEGRATE_REVIEW=#38852 from yashykt:RelandOTelTracing 4935227
PiperOrigin-RevId: 732160697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markdroth markdroth markdroth approved these changes

Assignees

No one assigned

Labels

bloat/none lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashykt @markdroth @grpc-kokoro