[XdsClient] Add missing authority to XdsClient metrics scope#38009
Closed
yashykt wants to merge 5 commits intogrpc:masterfrom
Closed
[XdsClient] Add missing authority to XdsClient metrics scope#38009yashykt wants to merge 5 commits intogrpc:masterfrom
yashykt wants to merge 5 commits intogrpc:masterfrom
Conversation
markdroth
reviewed
Oct 28, 2024
markdroth
approved these changes
Oct 28, 2024
Member
markdroth
left a comment
There was a problem hiding this comment.
Just one more minor comment to fix; feel free to merge after addressing.
markdroth
approved these changes
Oct 28, 2024
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Oct 29, 2024
) Fix for b/365993761. Noticed that XdsClient metrics were not being reported due to authority not being properly set. This solution is not perfect since channels created later can possibly use a different authority, so preferring to use the default authority from the first channel. Closes grpc#38009 COPYBARA_INTEGRATE_REVIEW=grpc#38009 from yashykt:AddAuthorityToXdsClientMetricsScope 00071ef PiperOrigin-RevId: 691149703
gnossen
pushed a commit
that referenced
this pull request
Oct 29, 2024
#38009) (#38023) Backport #38009 to 1.68.x Fix for b/365993761. Noticed that XdsClient metrics were not being reported due to authority not being properly set. This solution is not perfect since channels created later can possibly use a different authority, so preferring to use the default authority from the first channel.
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 6, 2024
) Fix for b/365993761. Noticed that XdsClient metrics were not being reported due to authority not being properly set. This solution is not perfect since channels created later can possibly use a different authority, so preferring to use the default authority from the first channel. Closes grpc#38009 COPYBARA_INTEGRATE_REVIEW=grpc#38009 from yashykt:AddAuthorityToXdsClientMetricsScope 00071ef PiperOrigin-RevId: 691149703
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
) Fix for b/365993761. Noticed that XdsClient metrics were not being reported due to authority not being properly set. This solution is not perfect since channels created later can possibly use a different authority, so preferring to use the default authority from the first channel. Closes grpc#38009 COPYBARA_INTEGRATE_REVIEW=grpc#38009 from yashykt:AddAuthorityToXdsClientMetricsScope 00071ef PiperOrigin-RevId: 691149703
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for b/365993761.
Noticed that XdsClient metrics were not being reported due to authority not being properly set.
This solution is not perfect since channels created later can possibly use a different authority, so preferring to use the default authority from the first channel.